Skip to content

Commit 9f944d2

Browse files
bjorn-rivospalmer-dabbelt
authored andcommitted
riscv: Require FRAME_POINTER for some configurations
Some V configurations implicitly turn on '-fno-omit-frame-pointer', but leaving FRAME_POINTER disabled. This makes it hard to reason about the FRAME_POINTER config, and also triggers build failures introduced in by the commit in the Fixes: tag. Select FRAME_POINTER explicitly for these configurations. Fixes: ebc9cb0 ("riscv: stack: Fixup independent softirq stack for CONFIG_FRAME_POINTER=n") Signed-off-by: Björn Töpel <[email protected]> Tested-by: Randy Dunlap <[email protected]> Acked-by: Randy Dunlap <[email protected]> Reviewed-by: Conor Dooley <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Palmer Dabbelt <[email protected]>
1 parent 174e8ac commit 9f944d2

File tree

2 files changed

+1
-3
lines changed

2 files changed

+1
-3
lines changed

arch/riscv/Kconfig

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -62,6 +62,7 @@ config RISCV
6262
select COMMON_CLK
6363
select CPU_PM if CPU_IDLE || HIBERNATION
6464
select EDAC_SUPPORT
65+
select FRAME_POINTER if PERF_EVENTS || (FUNCTION_TRACER && !DYNAMIC_FTRACE)
6566
select GENERIC_ARCH_TOPOLOGY
6667
select GENERIC_ATOMIC64 if !64BIT
6768
select GENERIC_CLOCKEVENTS_BROADCAST if SMP

arch/riscv/Makefile

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -87,9 +87,6 @@ endif
8787
ifeq ($(CONFIG_CMODEL_MEDANY),y)
8888
KBUILD_CFLAGS += -mcmodel=medany
8989
endif
90-
ifeq ($(CONFIG_PERF_EVENTS),y)
91-
KBUILD_CFLAGS += -fno-omit-frame-pointer
92-
endif
9390

9491
# Avoid generating .eh_frame sections.
9592
KBUILD_CFLAGS += -fno-asynchronous-unwind-tables -fno-unwind-tables

0 commit comments

Comments
 (0)