Skip to content

Commit 9fd4236

Browse files
kvaneeshmpe
authored andcommitted
powerpc/kvm/book3s: Use find_kvm_host_pte in kvmppc_get_hpa
Signed-off-by: Aneesh Kumar K.V <[email protected]> Signed-off-by: Michael Ellerman <[email protected]> Link: https://lore.kernel.org/r/[email protected]
1 parent bda3dea commit 9fd4236

File tree

1 file changed

+11
-21
lines changed

1 file changed

+11
-21
lines changed

arch/powerpc/kvm/book3s_hv_rm_mmu.c

Lines changed: 11 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -878,8 +878,8 @@ long kvmppc_h_clear_mod(struct kvm_vcpu *vcpu, unsigned long flags,
878878
return ret;
879879
}
880880

881-
static int kvmppc_get_hpa(struct kvm_vcpu *vcpu, unsigned long gpa,
882-
int writing, unsigned long *hpa,
881+
static int kvmppc_get_hpa(struct kvm_vcpu *vcpu, unsigned long mmu_seq,
882+
unsigned long gpa, int writing, unsigned long *hpa,
883883
struct kvm_memory_slot **memslot_p)
884884
{
885885
struct kvm *kvm = vcpu->kvm;
@@ -898,7 +898,7 @@ static int kvmppc_get_hpa(struct kvm_vcpu *vcpu, unsigned long gpa,
898898
hva = __gfn_to_hva_memslot(memslot, gfn);
899899

900900
/* Try to find the host pte for that virtual address */
901-
ptep = __find_linux_pte(vcpu->arch.pgdir, hva, NULL, &shift);
901+
ptep = find_kvm_host_pte(kvm, mmu_seq, hva, &shift);
902902
if (!ptep)
903903
return H_TOO_HARD;
904904
pte = kvmppc_read_update_linux_pte(ptep, writing);
@@ -933,16 +933,11 @@ static long kvmppc_do_h_page_init_zero(struct kvm_vcpu *vcpu,
933933
mmu_seq = kvm->mmu_notifier_seq;
934934
smp_rmb();
935935

936-
ret = kvmppc_get_hpa(vcpu, dest, 1, &pa, &memslot);
937-
if (ret != H_SUCCESS)
938-
return ret;
939-
940-
/* Check if we've been invalidated */
941936
arch_spin_lock(&kvm->mmu_lock.rlock.raw_lock);
942-
if (mmu_notifier_retry(kvm, mmu_seq)) {
943-
ret = H_TOO_HARD;
937+
938+
ret = kvmppc_get_hpa(vcpu, mmu_seq, dest, 1, &pa, &memslot);
939+
if (ret != H_SUCCESS)
944940
goto out_unlock;
945-
}
946941

947942
/* Zero the page */
948943
for (i = 0; i < SZ_4K; i += L1_CACHE_BYTES, pa += L1_CACHE_BYTES)
@@ -966,19 +961,14 @@ static long kvmppc_do_h_page_init_copy(struct kvm_vcpu *vcpu,
966961
mmu_seq = kvm->mmu_notifier_seq;
967962
smp_rmb();
968963

969-
ret = kvmppc_get_hpa(vcpu, dest, 1, &dest_pa, &dest_memslot);
970-
if (ret != H_SUCCESS)
971-
return ret;
972-
ret = kvmppc_get_hpa(vcpu, src, 0, &src_pa, NULL);
964+
arch_spin_lock(&kvm->mmu_lock.rlock.raw_lock);
965+
ret = kvmppc_get_hpa(vcpu, mmu_seq, dest, 1, &dest_pa, &dest_memslot);
973966
if (ret != H_SUCCESS)
974-
return ret;
967+
goto out_unlock;
975968

976-
/* Check if we've been invalidated */
977-
arch_spin_lock(&kvm->mmu_lock.rlock.raw_lock);
978-
if (mmu_notifier_retry(kvm, mmu_seq)) {
979-
ret = H_TOO_HARD;
969+
ret = kvmppc_get_hpa(vcpu, mmu_seq, src, 0, &src_pa, NULL);
970+
if (ret != H_SUCCESS)
980971
goto out_unlock;
981-
}
982972

983973
/* Copy the page */
984974
memcpy((void *)dest_pa, (void *)src_pa, SZ_4K);

0 commit comments

Comments
 (0)