Skip to content

Commit a003c38

Browse files
dangowrtkuba-moo
authored andcommitted
net: pcs: pcs-mtk-lynxi: correctly report in-band status capabilities
Neither does the LynxI PCS support QSGMII, nor is in-band-status supported in 2500Base-X mode. Fix the pcs_inband_caps() method accordingly. Fixes: 520d29b ("net: pcs: pcs-mtk-lynxi: implement pcs_inband_caps() method") Signed-off-by: Daniel Golle <[email protected]> Link: https://patch.msgid.link/[email protected] Signed-off-by: Jakub Kicinski <[email protected]>
1 parent 385f186 commit a003c38

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

drivers/net/pcs/pcs-mtk-lynxi.c

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -93,11 +93,12 @@ static unsigned int mtk_pcs_lynxi_inband_caps(struct phylink_pcs *pcs,
9393
{
9494
switch (interface) {
9595
case PHY_INTERFACE_MODE_1000BASEX:
96-
case PHY_INTERFACE_MODE_2500BASEX:
9796
case PHY_INTERFACE_MODE_SGMII:
98-
case PHY_INTERFACE_MODE_QSGMII:
9997
return LINK_INBAND_DISABLE | LINK_INBAND_ENABLE;
10098

99+
case PHY_INTERFACE_MODE_2500BASEX:
100+
return LINK_INBAND_DISABLE;
101+
101102
default:
102103
return 0;
103104
}

0 commit comments

Comments
 (0)