Skip to content

Commit a03b18a

Browse files
nfrapradokuba-moo
authored andcommitted
net: stmmac: dwmac-mediatek: Fix inverted handling of mediatek,mac-wol
The mediatek,mac-wol property is being handled backwards to what is described in the binding: it currently enables PHY WOL when the property is present and vice versa. Invert the driver logic so it matches the binding description. Fixes: fd1d62d ("net: stmmac: replace the use_phy_wol field with a flag") Signed-off-by: Nícolas F. R. A. Prado <[email protected]> Link: https://patch.msgid.link/20241109-mediatek-mac-wol-noninverted-v2-1-0e264e213878@collabora.com Signed-off-by: Jakub Kicinski <[email protected]>
1 parent e28acc9 commit a03b18a

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

drivers/net/ethernet/stmicro/stmmac/dwmac-mediatek.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -589,9 +589,9 @@ static int mediatek_dwmac_common_data(struct platform_device *pdev,
589589

590590
plat->mac_interface = priv_plat->phy_mode;
591591
if (priv_plat->mac_wol)
592-
plat->flags |= STMMAC_FLAG_USE_PHY_WOL;
593-
else
594592
plat->flags &= ~STMMAC_FLAG_USE_PHY_WOL;
593+
else
594+
plat->flags |= STMMAC_FLAG_USE_PHY_WOL;
595595
plat->riwt_off = 1;
596596
plat->maxmtu = ETH_DATA_LEN;
597597
plat->host_dma_width = priv_plat->variant->dma_bit_mask;

0 commit comments

Comments
 (0)