bcachefs: Set bch_inode_unpacked.bi_snapshot in old inode path

Kent Overstreet · Kent Overstreet · commit a069f014797f · 2024-10-20T18:09:09.000-04:00
This fixes a fsck bug on a very old filesystem (pre mainline merge). Fixes: 72350ee ("bcachefs: Kill snapshot arg to fsck_write_inode()") Reported-by: Marcin Mirosław <marcin@mejor.pl> Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
diff --git a/fs/bcachefs/inode.c b/fs/bcachefs/inode.c
@@ -283,6 +283,8 @@ static noinline int bch2_inode_unpack_slowpath(struct bkey_s_c k,
 {
 	memset(unpacked, 0, sizeof(*unpacked));
 
+	unpacked->bi_snapshot = k.k->p.snapshot;
+
 	switch (k.k->type) {
 	case KEY_TYPE_inode: {
 		struct bkey_s_c_inode inode = bkey_s_c_to_inode(k);

Original file line number	Diff line number	Diff line change
`@@ -283,6 +283,8 @@ static noinline int bch2_inode_unpack_slowpath(struct bkey_s_c k,`
`283`	`283`	`{`
`284`	`284`	`memset(unpacked, 0, sizeof(*unpacked));`
`285`	`285`
	`286`	`+ unpacked->bi_snapshot = k.k->p.snapshot;`
	`287`	`+`
`286`	`288`	`switch (k.k->type) {`
`287`	`289`	`case KEY_TYPE_inode: {`
`288`	`290`	`struct bkey_s_c_inode inode = bkey_s_c_to_inode(k);`