Skip to content

Commit a0948dd

Browse files
sriedmuellerWim Van Sebroeck
authored andcommitted
watchdog: da9062: No need to ping manually before setting timeout
There is actually no need to ping the watchdog before disabling it during timeout change. Disabling the watchdog already takes care of resetting the counter. This fixes an issue during boot when the userspace watchdog handler takes over and the watchdog is already running. Opening the watchdog in this case leads to the first ping and directly after that without the required heartbeat delay a second ping issued by the set_timeout call. Due to the missing delay this resulted in a reset. Signed-off-by: Stefan Riedmueller <[email protected]> Reviewed-by: Guenter Roeck <[email protected]> Reviewed-by: Adam Thomson <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Guenter Roeck <[email protected]> Signed-off-by: Wim Van Sebroeck <[email protected]>
1 parent c471830 commit a0948dd

File tree

1 file changed

+0
-5
lines changed

1 file changed

+0
-5
lines changed

drivers/watchdog/da9062_wdt.c

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -67,11 +67,6 @@ static int da9062_wdt_update_timeout_register(struct da9062_watchdog *wdt,
6767
unsigned int regval)
6868
{
6969
struct da9062 *chip = wdt->hw;
70-
int ret;
71-
72-
ret = da9062_reset_watchdog_timer(wdt);
73-
if (ret)
74-
return ret;
7570

7671
regmap_update_bits(chip->regmap,
7772
DA9062AA_CONTROL_D,

0 commit comments

Comments
 (0)