Skip to content

Commit a0a4d17

Browse files
committed
Merge branch 'pcmcia-next' of git://git.kernel.org/pub/scm/linux/kernel/git/brodo/linux
Pull pcmcia updates from Dominik Brodowski: "Two minor PCMCIA odd fixes: one replacing zero-length arrays with a flexible-array member, and one making a local function static" * 'pcmcia-next' of git://git.kernel.org/pub/scm/linux/kernel/git/brodo/linux: pcmcia: make pccard_loop_tuple() static pcmcia: Replace zero-length array with flexible-array
2 parents 86c67ce + 46d0797 commit a0a4d17

File tree

3 files changed

+6
-12
lines changed

3 files changed

+6
-12
lines changed

drivers/pcmcia/cs_internal.h

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -164,12 +164,6 @@ int pcmcia_replace_cis(struct pcmcia_socket *s,
164164
int pccard_validate_cis(struct pcmcia_socket *s, unsigned int *count);
165165
int verify_cis_cache(struct pcmcia_socket *s);
166166

167-
int pccard_loop_tuple(struct pcmcia_socket *s, unsigned int function,
168-
cisdata_t code, cisparse_t *parse, void *priv_data,
169-
int (*loop_tuple) (tuple_t *tuple,
170-
cisparse_t *parse,
171-
void *priv_data));
172-
173167
int pccard_get_first_tuple(struct pcmcia_socket *s, unsigned int function,
174168
tuple_t *tuple);
175169

drivers/pcmcia/pcmcia_cis.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -78,9 +78,9 @@ int pccard_read_tuple(struct pcmcia_socket *s, unsigned int function,
7878
* calls the @loop_tuple function for each entry. If the call to @loop_tuple
7979
* returns 0, the loop exits. Returns 0 on success or errorcode otherwise.
8080
*/
81-
int pccard_loop_tuple(struct pcmcia_socket *s, unsigned int function,
82-
cisdata_t code, cisparse_t *parse, void *priv_data,
83-
int (*loop_tuple) (tuple_t *tuple,
81+
static int pccard_loop_tuple(struct pcmcia_socket *s, unsigned int function,
82+
cisdata_t code, cisparse_t *parse, void *priv_data,
83+
int (*loop_tuple) (tuple_t *tuple,
8484
cisparse_t *parse,
8585
void *priv_data))
8686
{

include/pcmcia/cistpl.h

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -161,7 +161,7 @@ typedef struct cistpl_funcid_t {
161161

162162
typedef struct cistpl_funce_t {
163163
u_char type;
164-
u_char data[0];
164+
u_char data[];
165165
} cistpl_funce_t;
166166

167167
/*======================================================================
@@ -255,7 +255,7 @@ typedef struct cistpl_data_serv_t {
255255
u_char escape;
256256
u_char encrypt;
257257
u_char misc_features;
258-
u_char ccitt_code[0];
258+
u_char ccitt_code[];
259259
} cistpl_data_serv_t;
260260

261261
typedef struct cistpl_fax_serv_t {
@@ -265,7 +265,7 @@ typedef struct cistpl_fax_serv_t {
265265
u_char encrypt;
266266
u_char features_0;
267267
u_char features_1;
268-
u_char ccitt_code[0];
268+
u_char ccitt_code[];
269269
} cistpl_fax_serv_t;
270270

271271
typedef struct cistpl_voice_serv_t {

0 commit comments

Comments
 (0)