Skip to content

Commit a0e6fbf

Browse files
stephan-ghandersson
authored andcommitted
arm64: dts: qcom: x1e80100-crd: Fix backlight
The backlight does not work correctly with the current display panel configuration: It works after boot, but once the display gets disabled it is not possible to get it back on. It turns out that the ATNA45AF01 panel needs exactly the same non-standard power sequence as implemented by the panel-samsung-atna33xc20 driver for sc7180-trogdor-homestar. Switch the panel in the DT to the new compatible and make two more changes to make it work correctly: 1. Add the missing GPIO for the panel EL_ON3 line (EDP_BL_EN on CRD and enable-gpios in the DT). 2. Drop the regulator-always-on for the panel regulator. The panel does not seem to power off properly if the regulator stays on. Fixes: d7e03cc ("arm64: dts: qcom: x1e80100-crd: Enable more support") Reviewed-by: Konrad Dybcio <[email protected]> Signed-off-by: Stephan Gerhold <[email protected]> Reviewed-by: Johan Hovold <[email protected]> Tested-by: Johan Hovold <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Bjorn Andersson <[email protected]>
1 parent 86c71c0 commit a0e6fbf

File tree

1 file changed

+15
-2
lines changed

1 file changed

+15
-2
lines changed

arch/arm64/boot/dts/qcom/x1e80100-crd.dts

Lines changed: 15 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -268,7 +268,6 @@
268268
pinctrl-0 = <&edp_reg_en>;
269269
pinctrl-names = "default";
270270

271-
regulator-always-on;
272271
regulator-boot-on;
273272
};
274273

@@ -724,9 +723,13 @@
724723

725724
aux-bus {
726725
panel {
727-
compatible = "edp-panel";
726+
compatible = "samsung,atna45af01", "samsung,atna33xc20";
727+
enable-gpios = <&pmc8380_3_gpios 4 GPIO_ACTIVE_HIGH>;
728728
power-supply = <&vreg_edp_3p3>;
729729

730+
pinctrl-0 = <&edp_bl_en>;
731+
pinctrl-names = "default";
732+
730733
port {
731734
edp_panel_in: endpoint {
732735
remote-endpoint = <&mdss_dp3_out>;
@@ -791,6 +794,16 @@
791794
status = "okay";
792795
};
793796

797+
&pmc8380_3_gpios {
798+
edp_bl_en: edp-bl-en-state {
799+
pins = "gpio4";
800+
function = "normal";
801+
power-source = <1>; /* 1.8V */
802+
input-disable;
803+
output-enable;
804+
};
805+
};
806+
794807
&qupv3_0 {
795808
status = "okay";
796809
};

0 commit comments

Comments
 (0)