Skip to content

Commit a0f81bf

Browse files
jpoimboeIngo Molnar
authored andcommitted
x86/unwind/orc: Fix error path for bad ORC entry type
If the ORC entry type is unknown, nothing else can be done other than reporting an error. Exit the function instead of breaking out of the switch statement. Fixes: ee9f8fc ("x86/unwind: Add the ORC unwinder") Reviewed-by: Miroslav Benes <[email protected]> Signed-off-by: Josh Poimboeuf <[email protected]> Signed-off-by: Ingo Molnar <[email protected]> Cc: Andy Lutomirski <[email protected]> Cc: Dave Jones <[email protected]> Cc: Jann Horn <[email protected]> Cc: Peter Zijlstra <[email protected]> Cc: Thomas Gleixner <[email protected]> Cc: Vince Weaver <[email protected]> Link: https://lore.kernel.org/r/a7fa668ca6eabbe81ab18b2424f15adbbfdc810a.1587808742.git.jpoimboe@redhat.com
1 parent 98d0c8e commit a0f81bf

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

arch/x86/kernel/unwind_orc.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -537,7 +537,7 @@ bool unwind_next_frame(struct unwind_state *state)
537537
default:
538538
orc_warn("unknown .orc_unwind entry type %d at %pB\n",
539539
orc->type, (void *)orig_ip);
540-
break;
540+
goto err;
541541
}
542542

543543
/* Find BP: */

0 commit comments

Comments
 (0)