Skip to content

Commit a1043fb

Browse files
scosubebarino
authored andcommitted
clk: mediatek: mt8365: Fix inverted topclk operations
The given operations are inverted for the wrong registers which makes multiple of the mt8365 hardware units unusable. In my setup at least usb did not work. Fixed by swapping the operations with the inverted ones. Reported-by: Alexandre Mergnat <[email protected]> Fixes: 905b743 ("clk: mediatek: mt8365: Convert simple_gate to mtk_gate clocks") Signed-off-by: Markus Schneider-Pargmann <[email protected]> Link: https://lore.kernel.org/r/[email protected] Tested-by: Alexandre Mergnat <[email protected]> Reviewed-by: Alexandre Mergnat <[email protected]> Reviewed-by: Matthias Brugger <[email protected]> Reviewed-by: AngeloGioacchino Del Regno <[email protected]> Signed-off-by: Stephen Boyd <[email protected]>
1 parent d54fb4b commit a1043fb

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

drivers/clk/mediatek/clk-mt8365.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -592,15 +592,15 @@ static const struct mtk_gate_regs top2_cg_regs = {
592592

593593
#define GATE_TOP0(_id, _name, _parent, _shift) \
594594
GATE_MTK(_id, _name, _parent, &top0_cg_regs, \
595-
_shift, &mtk_clk_gate_ops_no_setclr_inv)
595+
_shift, &mtk_clk_gate_ops_no_setclr)
596596

597597
#define GATE_TOP1(_id, _name, _parent, _shift) \
598598
GATE_MTK(_id, _name, _parent, &top1_cg_regs, \
599-
_shift, &mtk_clk_gate_ops_no_setclr)
599+
_shift, &mtk_clk_gate_ops_no_setclr_inv)
600600

601601
#define GATE_TOP2(_id, _name, _parent, _shift) \
602602
GATE_MTK(_id, _name, _parent, &top2_cg_regs, \
603-
_shift, &mtk_clk_gate_ops_no_setclr)
603+
_shift, &mtk_clk_gate_ops_no_setclr_inv)
604604

605605
static const struct mtk_gate top_clk_gates[] = {
606606
GATE_TOP0(CLK_TOP_CONN_32K, "conn_32k", "clk32k", 10),

0 commit comments

Comments
 (0)