Skip to content

Commit a111749

Browse files
Sakari Ailusrafaeljw
authored andcommitted
Documentation: ACPI: Fix data node reference documentation
The data node reference documentation was missing a package that must contain the property values, instead property name and multiple values being present in a single package. This is not aligned with the _DSD spec. Fix it by adding the package for the values. Also add the missing "reg" properties to two numbered nodes. Fixes: b10134a ("ACPI: property: Document hierarchical data extension references") Signed-off-by: Sakari Ailus <[email protected]> Reviewed-by: Andy Shevchenko <[email protected]> Signed-off-by: Rafael J. Wysocki <[email protected]>
1 parent 49f39cb commit a111749

File tree

1 file changed

+8
-2
lines changed

1 file changed

+8
-2
lines changed

Documentation/firmware-guide/acpi/dsd/data-node-references.rst

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
Referencing hierarchical data nodes
66
===================================
77

8-
:Copyright: |copy| 2018 Intel Corporation
8+
:Copyright: |copy| 2018, 2021 Intel Corporation
99
:Author: Sakari Ailus <[email protected]>
1010

1111
ACPI in general allows referring to device objects in the tree only.
@@ -52,12 +52,14 @@ the ANOD object which is also the final target node of the reference.
5252
Name (NOD0, Package() {
5353
ToUUID("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"),
5454
Package () {
55+
Package () { "reg", 0 },
5556
Package () { "random-property", 3 },
5657
}
5758
})
5859
Name (NOD1, Package() {
5960
ToUUID("dbb8e3e6-5886-4ba6-8795-1319f52a966b"),
6061
Package () {
62+
Package () { "reg", 1 },
6163
Package () { "anothernode", "ANOD" },
6264
}
6365
})
@@ -74,7 +76,11 @@ the ANOD object which is also the final target node of the reference.
7476
Name (_DSD, Package () {
7577
ToUUID("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"),
7678
Package () {
77-
Package () { "reference", ^DEV0, "node@1", "anothernode" },
79+
Package () {
80+
"reference", Package () {
81+
^DEV0, "node@1", "anothernode"
82+
}
83+
},
7884
}
7985
})
8086
}

0 commit comments

Comments
 (0)