Skip to content

Commit a150c68

Browse files
ekanshibugregkh
authored andcommitted
misc: fastrpc: Add missing dev_err newlines
Few dev_err calls are missing newlines. This can result in unrelated lines getting appended which might make logs difficult to understand. Add trailing newlines to avoid this. Signed-off-by: Ekansh Gupta <[email protected]> Reviewed-by: Dmitry Baryshkov <[email protected]> Reviewed-by: Caleb Connolly <[email protected]> Signed-off-by: Srinivas Kandagatla <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>
1 parent f0f5336 commit a150c68

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

drivers/misc/fastrpc.c

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -325,7 +325,7 @@ static void fastrpc_free_map(struct kref *ref)
325325
err = qcom_scm_assign_mem(map->phys, map->size,
326326
&src_perms, &perm, 1);
327327
if (err) {
328-
dev_err(map->fl->sctx->dev, "Failed to assign memory phys 0x%llx size 0x%llx err %d",
328+
dev_err(map->fl->sctx->dev, "Failed to assign memory phys 0x%llx size 0x%llx err %d\n",
329329
map->phys, map->size, err);
330330
return;
331331
}
@@ -816,7 +816,7 @@ static int fastrpc_map_create(struct fastrpc_user *fl, int fd,
816816
map->attr = attr;
817817
err = qcom_scm_assign_mem(map->phys, (u64)map->size, &src_perms, dst_perms, 2);
818818
if (err) {
819-
dev_err(sess->dev, "Failed to assign memory with phys 0x%llx size 0x%llx err %d",
819+
dev_err(sess->dev, "Failed to assign memory with phys 0x%llx size 0x%llx err %d\n",
820820
map->phys, map->size, err);
821821
goto map_err;
822822
}
@@ -1222,7 +1222,7 @@ static bool is_session_rejected(struct fastrpc_user *fl, bool unsigned_pd_reques
12221222
* that does not support unsigned PD offload
12231223
*/
12241224
if (!fl->cctx->unsigned_support || !unsigned_pd_request) {
1225-
dev_err(&fl->cctx->rpdev->dev, "Error: Untrusted application trying to offload to signed PD");
1225+
dev_err(&fl->cctx->rpdev->dev, "Error: Untrusted application trying to offload to signed PD\n");
12261226
return true;
12271227
}
12281228
}
@@ -1280,7 +1280,7 @@ static int fastrpc_init_create_static_process(struct fastrpc_user *fl,
12801280
&src_perms,
12811281
fl->cctx->vmperms, fl->cctx->vmcount);
12821282
if (err) {
1283-
dev_err(fl->sctx->dev, "Failed to assign memory with phys 0x%llx size 0x%llx err %d",
1283+
dev_err(fl->sctx->dev, "Failed to assign memory with phys 0x%llx size 0x%llx err %d\n",
12841284
fl->cctx->remote_heap->phys, fl->cctx->remote_heap->size, err);
12851285
goto err_map;
12861286
}
@@ -1332,7 +1332,7 @@ static int fastrpc_init_create_static_process(struct fastrpc_user *fl,
13321332
(u64)fl->cctx->remote_heap->size,
13331333
&src_perms, &dst_perms, 1);
13341334
if (err)
1335-
dev_err(fl->sctx->dev, "Failed to assign memory phys 0x%llx size 0x%llx err %d",
1335+
dev_err(fl->sctx->dev, "Failed to assign memory phys 0x%llx size 0x%llx err %d\n",
13361336
fl->cctx->remote_heap->phys, fl->cctx->remote_heap->size, err);
13371337
}
13381338
err_map:

0 commit comments

Comments
 (0)