Skip to content

Commit a176e11

Browse files
crorvickKalle Valo
authored andcommitted
iwlwifi: actually check allocated conf_tlv pointer
Commit 71bc033 ("iwlwifi: check allocated pointer when allocating conf_tlvs") attempted to fix a typoe introduced by commit 17b809c ("iwlwifi: dbg: move debug data to a struct") but does not implement the check correctly. Fixes: 71bc033 ("iwlwifi: check allocated pointer when allocating conf_tlvs") Tweeted-by: @grsecurity Signed-off-by: Chris Rorvick <[email protected]> Signed-off-by: Sedat Dilek <[email protected]> Signed-off-by: Kalle Valo <[email protected]> Link: https://lore.kernel.org/r/[email protected]
1 parent 1f8fbe9 commit a176e11

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/net/wireless/intel/iwlwifi/iwl-drv.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1467,7 +1467,7 @@ static void iwl_req_fw_callback(const struct firmware *ucode_raw, void *context)
14671467
kmemdup(pieces->dbg_conf_tlv[i],
14681468
pieces->dbg_conf_tlv_len[i],
14691469
GFP_KERNEL);
1470-
if (!pieces->dbg_conf_tlv[i])
1470+
if (!drv->fw.dbg.conf_tlv[i])
14711471
goto out_free_fw;
14721472
}
14731473
}

0 commit comments

Comments
 (0)