Skip to content

Commit a1a824f

Browse files
committed
genetlink: fix kdoc warnings
Address a bunch of kdoc warnings: include/net/genetlink.h:81: warning: Function parameter or member 'module' not described in 'genl_family' include/net/genetlink.h:243: warning: expecting prototype for struct genl_info. Prototype was for struct genl_dumpit_info instead include/net/genetlink.h:419: warning: Function parameter or member 'net' not described in 'genlmsg_unicast' include/net/genetlink.h:438: warning: expecting prototype for gennlmsg_data(). Prototype was for genlmsg_data() instead include/net/genetlink.h:244: warning: Function parameter or member 'op' not described in 'genl_dumpit_info' Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Jakub Kicinski <[email protected]>
1 parent 6109ecb commit a1a824f

File tree

1 file changed

+5
-3
lines changed

1 file changed

+5
-3
lines changed

include/net/genetlink.h

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,7 @@ struct genl_info;
3737
* do additional, common, filtering and return an error
3838
* @post_doit: called after an operation's doit callback, it may
3939
* undo operations done by pre_doit, for example release locks
40+
* @module: pointer to the owning module (set to THIS_MODULE)
4041
* @mcgrps: multicast groups used by this family
4142
* @n_mcgrps: number of multicast groups
4243
* @resv_start_op: first operation for which reserved fields of the header
@@ -173,9 +174,9 @@ struct genl_ops {
173174
};
174175

175176
/**
176-
* struct genl_info - info that is available during dumpit op call
177+
* struct genl_dumpit_info - info that is available during dumpit op call
177178
* @family: generic netlink family - for internal genl code usage
178-
* @ops: generic netlink ops - for internal genl code usage
179+
* @op: generic netlink ops - for internal genl code usage
179180
* @attrs: netlink attributes
180181
*/
181182
struct genl_dumpit_info {
@@ -354,6 +355,7 @@ int genlmsg_multicast_allns(const struct genl_family *family,
354355

355356
/**
356357
* genlmsg_unicast - unicast a netlink message
358+
* @net: network namespace to look up @portid in
357359
* @skb: netlink message as socket buffer
358360
* @portid: netlink portid of the destination socket
359361
*/
@@ -373,7 +375,7 @@ static inline int genlmsg_reply(struct sk_buff *skb, struct genl_info *info)
373375
}
374376

375377
/**
376-
* gennlmsg_data - head of message payload
378+
* genlmsg_data - head of message payload
377379
* @gnlh: genetlink message header
378380
*/
379381
static inline void *genlmsg_data(const struct genlmsghdr *gnlh)

0 commit comments

Comments
 (0)