Skip to content

Commit a1c4b92

Browse files
rio.h: Replace zero-length array with flexible-array member
The current codebase makes use of the zero-length array language extension to the C90 standard, but the preferred mechanism to declare variable-length types such as these ones is a flexible array member[1][2], introduced in C99: struct foo { int stuff; struct boo array[]; }; By making use of the mechanism above, we will get a compiler warning in case the flexible array does not occur last in the structure, which will help us prevent some kind of undefined behavior bugs from being inadvertently introduced[3] to the codebase from now on. Also, notice that, dynamic memory allocations won't be affected by this change: "Flexible array members have incomplete type, and so the sizeof operator may not be applied. As a quirk of the original implementation of zero-length arrays, sizeof evaluates to zero."[1] This issue was found with the help of Coccinelle. [1] https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html [2] KSPP#21 [3] commit 7649773 ("cxgb3/l2t: Fix undefined behaviour") Signed-off-by: Gustavo A. R. Silva <[email protected]>
1 parent 70f1451 commit a1c4b92

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

include/linux/rio.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,7 @@ struct rio_switch {
100100
u32 port_ok;
101101
struct rio_switch_ops *ops;
102102
spinlock_t lock;
103-
struct rio_dev *nextdev[0];
103+
struct rio_dev *nextdev[];
104104
};
105105

106106
/**
@@ -201,7 +201,7 @@ struct rio_dev {
201201
u8 hopcount;
202202
struct rio_dev *prev;
203203
atomic_t state;
204-
struct rio_switch rswitch[0]; /* RIO switch info */
204+
struct rio_switch rswitch[]; /* RIO switch info */
205205
};
206206

207207
#define rio_dev_g(n) list_entry(n, struct rio_dev, global_list)

0 commit comments

Comments
 (0)