Skip to content

Commit a20f1b0

Browse files
committed
drm/bridge: parade-ps8640: Make sure we drop the AUX mutex in the error case
After commit 26db46b ("drm/bridge: parade-ps8640: Ensure bridge is suspended in .post_disable()"), if we hit the error case in ps8640_aux_transfer() then we return without dropping the mutex. Fix this oversight. Fixes: 26db46b ("drm/bridge: parade-ps8640: Ensure bridge is suspended in .post_disable()") Reviewed-by: Hsin-Yi Wang <[email protected]> Signed-off-by: Douglas Anderson <[email protected]> Link: https://patchwork.freedesktop.org/patch/msgid/20240117103502.1.Ib726a0184913925efc7e99c4d4fc801982e1bc24@changeid
1 parent 26db46b commit a20f1b0

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

drivers/gpu/drm/bridge/parade-ps8640.c

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -351,11 +351,13 @@ static ssize_t ps8640_aux_transfer(struct drm_dp_aux *aux,
351351
ret = _ps8640_wait_hpd_asserted(ps_bridge, 200 * 1000);
352352
if (ret) {
353353
pm_runtime_put_sync_suspend(dev);
354-
return ret;
354+
goto exit;
355355
}
356356
ret = ps8640_aux_transfer_msg(aux, msg);
357357
pm_runtime_mark_last_busy(dev);
358358
pm_runtime_put_autosuspend(dev);
359+
360+
exit:
359361
mutex_unlock(&ps_bridge->aux_lock);
360362

361363
return ret;

0 commit comments

Comments
 (0)