Skip to content

Commit a24823d

Browse files
committed
Merge tag 'drm-xe-fixes-2025-06-12' of https://gitlab.freedesktop.org/drm/xe/kernel into drm-fixes
Driver Changes: - Fix regression disallowing 64K SVM migration (Maarten) - Use a bounce buffer for WA BB (Lucas) Signed-off-by: Dave Airlie <[email protected]> From: Thomas Hellstrom <[email protected]> Link: https://lore.kernel.org/r/aEsBQoh5Si3ouPgE@fedora
2 parents 19272b3 + 9c7632f commit a24823d

File tree

2 files changed

+21
-5
lines changed

2 files changed

+21
-5
lines changed

drivers/gpu/drm/xe/xe_lrc.c

Lines changed: 20 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -941,11 +941,18 @@ static void xe_lrc_finish(struct xe_lrc *lrc)
941941
* store it in the PPHSWP.
942942
*/
943943
#define CONTEXT_ACTIVE 1ULL
944-
static void xe_lrc_setup_utilization(struct xe_lrc *lrc)
944+
static int xe_lrc_setup_utilization(struct xe_lrc *lrc)
945945
{
946-
u32 *cmd;
946+
u32 *cmd, *buf = NULL;
947947

948-
cmd = lrc->bb_per_ctx_bo->vmap.vaddr;
948+
if (lrc->bb_per_ctx_bo->vmap.is_iomem) {
949+
buf = kmalloc(lrc->bb_per_ctx_bo->size, GFP_KERNEL);
950+
if (!buf)
951+
return -ENOMEM;
952+
cmd = buf;
953+
} else {
954+
cmd = lrc->bb_per_ctx_bo->vmap.vaddr;
955+
}
949956

950957
*cmd++ = MI_STORE_REGISTER_MEM | MI_SRM_USE_GGTT | MI_SRM_ADD_CS_OFFSET;
951958
*cmd++ = ENGINE_ID(0).addr;
@@ -966,9 +973,16 @@ static void xe_lrc_setup_utilization(struct xe_lrc *lrc)
966973

967974
*cmd++ = MI_BATCH_BUFFER_END;
968975

976+
if (buf) {
977+
xe_map_memcpy_to(gt_to_xe(lrc->gt), &lrc->bb_per_ctx_bo->vmap, 0,
978+
buf, (cmd - buf) * sizeof(*cmd));
979+
kfree(buf);
980+
}
981+
969982
xe_lrc_write_ctx_reg(lrc, CTX_BB_PER_CTX_PTR,
970983
xe_bo_ggtt_addr(lrc->bb_per_ctx_bo) | 1);
971984

985+
return 0;
972986
}
973987

974988
#define PVC_CTX_ASID (0x2e + 1)
@@ -1125,7 +1139,9 @@ static int xe_lrc_init(struct xe_lrc *lrc, struct xe_hw_engine *hwe,
11251139
map = __xe_lrc_start_seqno_map(lrc);
11261140
xe_map_write32(lrc_to_xe(lrc), &map, lrc->fence_ctx.next_seqno - 1);
11271141

1128-
xe_lrc_setup_utilization(lrc);
1142+
err = xe_lrc_setup_utilization(lrc);
1143+
if (err)
1144+
goto err_lrc_finish;
11291145

11301146
return 0;
11311147

drivers/gpu/drm/xe/xe_svm.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -764,7 +764,7 @@ static bool xe_svm_range_needs_migrate_to_vram(struct xe_svm_range *range,
764764
return false;
765765
}
766766

767-
if (range_size <= SZ_64K && !supports_4K_migration(vm->xe)) {
767+
if (range_size < SZ_64K && !supports_4K_migration(vm->xe)) {
768768
drm_dbg(&vm->xe->drm, "Platform doesn't support SZ_4K range migration\n");
769769
return false;
770770
}

0 commit comments

Comments
 (0)