Skip to content

Commit a26cc29

Browse files
Saravana Kannanmripard
authored andcommitted
drm/mipi-dsi: Set the fwnode for mipi_dsi_device
After commit 3fb1686 ("driver core: fw_devlink: Make cycle detection more robust"), fw_devlink prints an error when consumer devices don't have their fwnode set. This used to be ignored silently. Set the fwnode mipi_dsi_device so fw_devlink can find them and properly track their dependencies. This fixes errors like this: [ 0.334054] nwl-dsi 30a00000.mipi-dsi: Failed to create device link with regulator-lcd-1v8 [ 0.346964] nwl-dsi 30a00000.mipi-dsi: Failed to create device link with backlight-dsi Reported-by: Martin Kepplinger <[email protected]> Link: https://lore.kernel.org/lkml/[email protected]/ Fixes: 068a002 ("drm: Add MIPI DSI bus support") Signed-off-by: Saravana Kannan <[email protected]> Tested-by: Martin Kepplinger <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Maxime Ripard <[email protected]>
1 parent 25feda6 commit a26cc29

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/gpu/drm/drm_mipi_dsi.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -221,7 +221,7 @@ mipi_dsi_device_register_full(struct mipi_dsi_host *host,
221221
return dsi;
222222
}
223223

224-
dsi->dev.of_node = info->node;
224+
device_set_node(&dsi->dev, of_fwnode_handle(info->node));
225225
dsi->channel = info->channel;
226226
strlcpy(dsi->name, info->type, sizeof(dsi->name));
227227

0 commit comments

Comments
 (0)