Skip to content

Commit a27748a

Browse files
claudiubezneabebarino
authored andcommitted
clk: at91: clk-master: mask mckr against layout->mask
Mask values read/written from/to MCKR against layout->mask as this mask may be different b/w PMC versions. Signed-off-by: Claudiu Beznea <[email protected]> Link: https://lore.kernel.org/r/[email protected] Acked-by: Nicolas Ferre <[email protected]> Signed-off-by: Stephen Boyd <[email protected]>
1 parent c2910c0 commit a27748a

File tree

1 file changed

+5
-2
lines changed

1 file changed

+5
-2
lines changed

drivers/clk/at91/clk-master.c

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -186,8 +186,8 @@ static int clk_master_div_set_rate(struct clk_hw *hw, unsigned long rate,
186186
if (ret)
187187
goto unlock;
188188

189-
tmp = mckr & master->layout->mask;
190-
tmp = (tmp >> MASTER_DIV_SHIFT) & MASTER_DIV_MASK;
189+
mckr &= master->layout->mask;
190+
tmp = (mckr >> MASTER_DIV_SHIFT) & MASTER_DIV_MASK;
191191
if (tmp == div)
192192
goto unlock;
193193

@@ -384,6 +384,7 @@ static unsigned long clk_master_pres_recalc_rate(struct clk_hw *hw,
384384
regmap_read(master->regmap, master->layout->offset, &val);
385385
spin_unlock_irqrestore(master->lock, flags);
386386

387+
val &= master->layout->mask;
387388
pres = (val >> master->layout->pres_shift) & MASTER_PRES_MASK;
388389
if (pres == 3 && characteristics->have_div3_pres)
389390
pres = 3;
@@ -403,6 +404,8 @@ static u8 clk_master_pres_get_parent(struct clk_hw *hw)
403404
regmap_read(master->regmap, master->layout->offset, &mckr);
404405
spin_unlock_irqrestore(master->lock, flags);
405406

407+
mckr &= master->layout->mask;
408+
406409
return mckr & AT91_PMC_CSS;
407410
}
408411

0 commit comments

Comments
 (0)