Skip to content

Commit a307638

Browse files
paulmckrcuFrederic Weisbecker
authored andcommitted
rcu: Permit start_poll_synchronize_rcu*() with interrupts disabled
The header comment for both start_poll_synchronize_rcu() and start_poll_synchronize_rcu_full() state that interrupts must be enabled when calling these two functions, and there is a lockdep assertion in start_poll_synchronize_rcu_common() enforcing this restriction. However, there is no need for this restrictions, as can be seen in call_rcu(), which does wakeups when interrupts are disabled. This commit therefore removes the lockdep assertion and the comments. Reported-by: Kent Overstreet <[email protected]> Signed-off-by: Paul E. McKenney <[email protected]> Reviewed-by: Neeraj Upadhyay <[email protected]> Signed-off-by: Frederic Weisbecker <[email protected]>
1 parent 481aa5f commit a307638

File tree

1 file changed

+0
-7
lines changed

1 file changed

+0
-7
lines changed

kernel/rcu/tree.c

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -4194,7 +4194,6 @@ static void start_poll_synchronize_rcu_common(void)
41944194
struct rcu_data *rdp;
41954195
struct rcu_node *rnp;
41964196

4197-
lockdep_assert_irqs_enabled();
41984197
local_irq_save(flags);
41994198
rdp = this_cpu_ptr(&rcu_data);
42004199
rnp = rdp->mynode;
@@ -4219,9 +4218,6 @@ static void start_poll_synchronize_rcu_common(void)
42194218
* grace period has elapsed in the meantime. If the needed grace period
42204219
* is not already slated to start, notifies RCU core of the need for that
42214220
* grace period.
4222-
*
4223-
* Interrupts must be enabled for the case where it is necessary to awaken
4224-
* the grace-period kthread.
42254221
*/
42264222
unsigned long start_poll_synchronize_rcu(void)
42274223
{
@@ -4242,9 +4238,6 @@ EXPORT_SYMBOL_GPL(start_poll_synchronize_rcu);
42424238
* grace period (whether normal or expedited) has elapsed in the meantime.
42434239
* If the needed grace period is not already slated to start, notifies
42444240
* RCU core of the need for that grace period.
4245-
*
4246-
* Interrupts must be enabled for the case where it is necessary to awaken
4247-
* the grace-period kthread.
42484241
*/
42494242
void start_poll_synchronize_rcu_full(struct rcu_gp_oldstate *rgosp)
42504243
{

0 commit comments

Comments
 (0)