Skip to content

Commit a32a805

Browse files
committed
Merge tag 'counter-fixes-for-6.12' of ssh://gitolite.kernel.org/pub/scm/linux/kernel/git/wbg/counter into char-misc-next
William writes: Counter fixes for 6.12 Fix device_node handling in stm32-timer-cnt by calling required of_node_put() after device node is no longer needed. Check and handle clk_enable() failures in stm32-timer-cnt and ti-ecap-capture. Signed-off-by: William Breathitt Gray <[email protected]> * tag 'counter-fixes-for-6.12' of ssh://gitolite.kernel.org/pub/scm/linux/kernel/git/wbg/counter: counter: ti-ecap-capture: Add check for clk_enable() counter: stm32-timer-cnt: Add check for clk_enable() counter: stm32-timer-cnt: fix device_node handling in probe_encoder()
2 parents 6cc685f + 1437d9f commit a32a805

File tree

2 files changed

+20
-4
lines changed

2 files changed

+20
-4
lines changed

drivers/counter/stm32-timer-cnt.c

Lines changed: 14 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -214,11 +214,17 @@ static int stm32_count_enable_write(struct counter_device *counter,
214214
{
215215
struct stm32_timer_cnt *const priv = counter_priv(counter);
216216
u32 cr1;
217+
int ret;
217218

218219
if (enable) {
219220
regmap_read(priv->regmap, TIM_CR1, &cr1);
220-
if (!(cr1 & TIM_CR1_CEN))
221-
clk_enable(priv->clk);
221+
if (!(cr1 & TIM_CR1_CEN)) {
222+
ret = clk_enable(priv->clk);
223+
if (ret) {
224+
dev_err(counter->parent, "Cannot enable clock %d\n", ret);
225+
return ret;
226+
}
227+
}
222228

223229
regmap_update_bits(priv->regmap, TIM_CR1, TIM_CR1_CEN,
224230
TIM_CR1_CEN);
@@ -694,6 +700,7 @@ static int stm32_timer_cnt_probe_encoder(struct device *dev,
694700
}
695701

696702
ret = of_property_read_u32(tnode, "reg", &idx);
703+
of_node_put(tnode);
697704
if (ret) {
698705
dev_err(dev, "Can't get index (%d)\n", ret);
699706
return ret;
@@ -816,7 +823,11 @@ static int __maybe_unused stm32_timer_cnt_resume(struct device *dev)
816823
return ret;
817824

818825
if (priv->enabled) {
819-
clk_enable(priv->clk);
826+
ret = clk_enable(priv->clk);
827+
if (ret) {
828+
dev_err(dev, "Cannot enable clock %d\n", ret);
829+
return ret;
830+
}
820831

821832
/* Restore registers that may have been lost */
822833
regmap_write(priv->regmap, TIM_SMCR, priv->bak.smcr);

drivers/counter/ti-ecap-capture.c

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -574,8 +574,13 @@ static int ecap_cnt_resume(struct device *dev)
574574
{
575575
struct counter_device *counter_dev = dev_get_drvdata(dev);
576576
struct ecap_cnt_dev *ecap_dev = counter_priv(counter_dev);
577+
int ret;
577578

578-
clk_enable(ecap_dev->clk);
579+
ret = clk_enable(ecap_dev->clk);
580+
if (ret) {
581+
dev_err(dev, "Cannot enable clock %d\n", ret);
582+
return ret;
583+
}
579584

580585
ecap_cnt_capture_set_evmode(counter_dev, ecap_dev->pm_ctx.ev_mode);
581586

0 commit comments

Comments
 (0)