Skip to content

Commit a350d2e

Browse files
Mian Yousaf Kaukabdavem330
authored andcommitted
net: thunderx: start phy before starting autonegotiation
Since commit 2b3e88e ("net: phy: improve phy state checking") phy_start_aneg() expects phy state to be >= PHY_UP. Call phy_start() before calling phy_start_aneg() during probe so that autonegotiation is initiated. As phy_start() takes care of calling phy_start_aneg(), drop the explicit call to phy_start_aneg(). Network fails without this patch on Octeon TX. Fixes: 2b3e88e ("net: phy: improve phy state checking") Signed-off-by: Mian Yousaf Kaukab <[email protected]> Reviewed-by: Andrew Lunn <[email protected]> Signed-off-by: David S. Miller <[email protected]>
1 parent df95467 commit a350d2e

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/net/ethernet/cavium/thunder/thunder_bgx.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1115,7 +1115,7 @@ static int bgx_lmac_enable(struct bgx *bgx, u8 lmacid)
11151115
phy_interface_mode(lmac->lmac_type)))
11161116
return -ENODEV;
11171117

1118-
phy_start_aneg(lmac->phydev);
1118+
phy_start(lmac->phydev);
11191119
return 0;
11201120
}
11211121

0 commit comments

Comments
 (0)