Skip to content

Commit a386c30

Browse files
lynxeye-devThomas Zimmermann
authored andcommitted
drm/atomic-helper: fix parameter order in drm_format_conv_state_copy() call
Old and new state parameters are swapped, so the old state was cleared instead of the new duplicated state. Fixes: 9036745 ("drm/atomic-helper: Add format-conversion state to shadow-plane state") Signed-off-by: Lucas Stach <[email protected]> Tested-by: Leonard Göhrs <[email protected]> Reviewed-by: Thomas Zimmermann <[email protected]> Cc: <[email protected]> # v6.8+ Signed-off-by: Thomas Zimmermann <[email protected]> Link: https://patchwork.freedesktop.org/patch/msgid/[email protected]
1 parent 6aff4c2 commit a386c30

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

drivers/gpu/drm/drm_gem_atomic_helper.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -224,8 +224,8 @@ __drm_gem_duplicate_shadow_plane_state(struct drm_plane *plane,
224224

225225
__drm_atomic_helper_plane_duplicate_state(plane, &new_shadow_plane_state->base);
226226

227-
drm_format_conv_state_copy(&shadow_plane_state->fmtcnv_state,
228-
&new_shadow_plane_state->fmtcnv_state);
227+
drm_format_conv_state_copy(&new_shadow_plane_state->fmtcnv_state,
228+
&shadow_plane_state->fmtcnv_state);
229229
}
230230
EXPORT_SYMBOL(__drm_gem_duplicate_shadow_plane_state);
231231

0 commit comments

Comments
 (0)