Skip to content

Commit a3b3d2d

Browse files
edumazetPaolo Abeni
authored andcommitted
net: hsr: remove synchronize_rcu() from hsr_add_port()
A synchronize_rcu() was added by mistake in commit c5a7591 ("net/hsr: Use list_head (and rcu) instead of array for slave devices.") RCU does not mandate to observe a grace period after list_add_tail_rcu(). Signed-off-by: Eric Dumazet <[email protected]> Reviewed-by: Simon Horman <[email protected]> Link: https://patch.msgid.link/[email protected] Signed-off-by: Paolo Abeni <[email protected]>
1 parent 2170a1f commit a3b3d2d

File tree

1 file changed

+0
-1
lines changed

1 file changed

+0
-1
lines changed

net/hsr/hsr_slave.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -204,7 +204,6 @@ int hsr_add_port(struct hsr_priv *hsr, struct net_device *dev,
204204
}
205205

206206
list_add_tail_rcu(&port->port_list, &hsr->ports);
207-
synchronize_rcu();
208207

209208
master = hsr_port_get_hsr(hsr, HSR_PT_MASTER);
210209
netdev_update_features(master->dev);

0 commit comments

Comments
 (0)