Skip to content

Commit a4332f6

Browse files
krzkandersson
authored andcommitted
firmware: qcom: scm: smc: Narrow 'mempool' variable scope
Only part of the __scm_smc_call() function uses 'mempool' variable, so narrow the scope to make it more readable. Reviewed-by: Bartosz Golaszewski <[email protected]> Signed-off-by: Krzysztof Kozlowski <[email protected]> Link: https://lore.kernel.org/r/20241209-qcom-scm-missing-barriers-and-all-sort-of-srap-v2-6-9061013c8d92@linaro.org Signed-off-by: Bjorn Andersson <[email protected]>
1 parent 94f48ec commit a4332f6

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

drivers/firmware/qcom/qcom_scm-smc.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -152,7 +152,6 @@ int __scm_smc_call(struct device *dev, const struct qcom_scm_desc *desc,
152152
enum qcom_scm_convention qcom_convention,
153153
struct qcom_scm_res *res, bool atomic)
154154
{
155-
struct qcom_tzmem_pool *mempool = qcom_scm_get_tzmem_pool();
156155
int arglen = desc->arginfo & 0xf;
157156
int i, ret;
158157
void *args_virt __free(qcom_tzmem) = NULL;
@@ -173,6 +172,8 @@ int __scm_smc_call(struct device *dev, const struct qcom_scm_desc *desc,
173172
smc.args[i + SCM_SMC_FIRST_REG_IDX] = desc->args[i];
174173

175174
if (unlikely(arglen > SCM_SMC_N_REG_ARGS)) {
175+
struct qcom_tzmem_pool *mempool = qcom_scm_get_tzmem_pool();
176+
176177
if (!mempool)
177178
return -EINVAL;
178179

0 commit comments

Comments
 (0)