Skip to content

Commit a48bba9

Browse files
committed
msm/fbdev: fix unused variable warning with clang.
clang builds showed this: drivers/gpu/drm/msm/msm_fbdev.c:144:6: error: variable 'helper' is used uninitialized whenever 'if' condition is true [-Werror,-Wsometimes-uninitialized] if (!fbdev) ^~~~~~ Fixes: 3fb1f62 ("drm/fb-helper: Remove drm_fb_helper_unprepare() from drm_fb_helper_fini()") Signed-off-by: Dave Airlie <[email protected]>
1 parent 13daf53 commit a48bba9

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/gpu/drm/msm/msm_fbdev.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -142,7 +142,7 @@ struct drm_fb_helper *msm_fbdev_init(struct drm_device *dev)
142142

143143
fbdev = kzalloc(sizeof(*fbdev), GFP_KERNEL);
144144
if (!fbdev)
145-
goto fail;
145+
return NULL;
146146

147147
helper = &fbdev->base;
148148

0 commit comments

Comments
 (0)