Skip to content

Commit a493911

Browse files
rfvirgilbroonie
authored andcommitted
firmware: cs_dsp: Clarify wmfw format version log message
Change the log message of the wmfw format version to include the file name, and change the message to say "format" instead of "Firmware version". Merge this with the message that logs the timestamp. The wmfw format version is information that is useful to have logged because the behaviour of firmware controls depends on the wmfw format. So "unexpected" behaviour could be caused by having expectations based on one format of wmfw when a different format has been loaded. But the original message was confusing. It reported the file format version but didn't actually log the name of the file it referred to. It also called it "Firmware version", which is confusing when a later message also logs a firmware version that is the version of the actual firmware within the wmfw. The logging of the firmware timestamp has been merged into this. That was originally a dbg-only message, but as we are already logging a line of info, we might as well add a few extra characters to log the timestamp. The timestamp is now logged in hexadecimal - it's not particularly useful as a decimal value. Signed-off-by: Richard Fitzgerald <[email protected]> Reviewed-by: Charles Keepax <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Mark Brown <[email protected]>
1 parent 584e86e commit a493911

File tree

1 file changed

+2
-3
lines changed

1 file changed

+2
-3
lines changed

drivers/firmware/cirrus/cs_dsp.c

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1499,7 +1499,6 @@ static int cs_dsp_load(struct cs_dsp *dsp, const struct firmware *firmware,
14991499
goto out_fw;
15001500
}
15011501

1502-
cs_dsp_info(dsp, "Firmware version: %d\n", header->ver);
15031502
dsp->fw_ver = header->ver;
15041503

15051504
if (header->core != dsp->type) {
@@ -1523,8 +1522,8 @@ static int cs_dsp_load(struct cs_dsp *dsp, const struct firmware *firmware,
15231522
goto out_fw;
15241523
}
15251524

1526-
cs_dsp_dbg(dsp, "%s: timestamp %llu\n", file,
1527-
le64_to_cpu(footer->timestamp));
1525+
cs_dsp_info(dsp, "%s: format %d timestamp %#llx\n", file, header->ver,
1526+
le64_to_cpu(footer->timestamp));
15281527

15291528
while (pos < firmware->size) {
15301529
/* Is there enough data for a complete block header? */

0 commit comments

Comments
 (0)