Skip to content

Commit a4b0f75

Browse files
author
Kent Overstreet
committed
bcachefs: Make journal read log message a bit quieter
Users seem to be assuming that the 'dropped unflushed entries' message at the end of journal read indicates some sort of problem, when it does not - we expect there to be entries in the journal that weren't commited, it's purely informational so that we can correlate journal sequence numbers elsewhere when debugging. Shorten the log message a bit to hopefully make this clearer. Signed-off-by: Kent Overstreet <[email protected]>
1 parent 29cc6fb commit a4b0f75

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

fs/bcachefs/journal_io.c

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1427,12 +1427,12 @@ int bch2_journal_read(struct bch_fs *c,
14271427
return 0;
14281428
}
14291429

1430-
bch_info(c, "journal read done, replaying entries %llu-%llu",
1431-
*last_seq, *blacklist_seq - 1);
1432-
1430+
printbuf_reset(&buf);
1431+
prt_printf(&buf, "journal read done, replaying entries %llu-%llu",
1432+
*last_seq, *blacklist_seq - 1);
14331433
if (*start_seq != *blacklist_seq)
1434-
bch_info(c, "dropped unflushed entries %llu-%llu",
1435-
*blacklist_seq, *start_seq - 1);
1434+
prt_printf(&buf, " (unflushed %llu-%llu)", *blacklist_seq, *start_seq - 1);
1435+
bch_info(c, "%s", buf.buf);
14361436

14371437
/* Drop blacklisted entries and entries older than last_seq: */
14381438
genradix_for_each(&c->journal_entries, radix_iter, _i) {

0 commit comments

Comments
 (0)