Skip to content

Commit a4e7596

Browse files
rodrigoviviThomas Hellström
authored andcommitted
drm/xe: Return immediately on tile_init failure
There's no reason to proceed with applying workaround and initing sysfs if we are going to abort the probe upon failure. Fixes: e5a845f ("drm/xe: Add sysfs entry for tile") Cc: Lucas De Marchi <[email protected]> Cc: Matt Roper <[email protected]> Cc: Matthew Auld <[email protected]> Reviewed-by: Matt Roper <[email protected]> Link: https://patchwork.freedesktop.org/patch/msgid/[email protected] Signed-off-by: Rodrigo Vivi <[email protected]> (cherry picked from commit af7b93d) Signed-off-by: Thomas Hellström <[email protected]>
1 parent 90d35da commit a4e7596

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

drivers/gpu/drm/xe/xe_tile.c

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -167,9 +167,10 @@ int xe_tile_init_noalloc(struct xe_tile *tile)
167167
goto err_mem_access;
168168

169169
tile->mem.kernel_bb_pool = xe_sa_bo_manager_init(tile, SZ_1M, 16);
170-
if (IS_ERR(tile->mem.kernel_bb_pool))
170+
if (IS_ERR(tile->mem.kernel_bb_pool)) {
171171
err = PTR_ERR(tile->mem.kernel_bb_pool);
172-
172+
goto err_mem_access;
173+
}
173174
xe_wa_apply_tile_workarounds(tile);
174175

175176
xe_tile_sysfs_init(tile);

0 commit comments

Comments
 (0)