Skip to content

Commit a53bcc1

Browse files
committed
gpu/drm: ingenic: Fix bogus crtc_atomic_check callback
The code was comparing the SoC's maximum height with the mode's width, and vice-versa. D'oh. Cc: [email protected] # v5.6 Fixes: a7c909b ("gpu/drm: ingenic: Check for display size in CRTC atomic check") Signed-off-by: Paul Cercueil <[email protected]> Link: https://patchwork.freedesktop.org/patch/msgid/[email protected] Acked-by: Sam Ravnborg <[email protected]>
1 parent c54a8f1 commit a53bcc1

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

drivers/gpu/drm/ingenic/ingenic-drm.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -328,8 +328,8 @@ static int ingenic_drm_crtc_atomic_check(struct drm_crtc *crtc,
328328
if (!drm_atomic_crtc_needs_modeset(state))
329329
return 0;
330330

331-
if (state->mode.hdisplay > priv->soc_info->max_height ||
332-
state->mode.vdisplay > priv->soc_info->max_width)
331+
if (state->mode.hdisplay > priv->soc_info->max_width ||
332+
state->mode.vdisplay > priv->soc_info->max_height)
333333
return -EINVAL;
334334

335335
rate = clk_round_rate(priv->pix_clk,

0 commit comments

Comments
 (0)