Skip to content

Commit a5c2320

Browse files
author
Thomas Zimmermann
committed
drm/ast: Warn about unsupported TX chips
A number of TX chips are listed in VGACRD1, but not supported by the ast driver. Whether any existing product uses such a chip is unknown. Warn if the driver encounters any. We can then add support as necessary. Signed-off-by: Thomas Zimmermann <[email protected]> Suggested-by: Jocelyn Falempe <[email protected]> Reviewed-by: Jocelyn Falempe <[email protected]> Link: https://patchwork.freedesktop.org/patch/msgid/[email protected]
1 parent f93d666 commit a5c2320

File tree

1 file changed

+16
-1
lines changed

1 file changed

+16
-1
lines changed

drivers/gpu/drm/ast/ast_main.c

Lines changed: 16 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,22 @@ static void ast_detect_tx_chip(struct ast_device *ast, bool need_post)
7676
};
7777

7878
struct drm_device *dev = &ast->base;
79-
u8 jreg;
79+
u8 jreg, vgacrd1;
80+
81+
/*
82+
* Several of the listed TX chips are not explicitly supported
83+
* by the ast driver. If these exist in real-world devices, they
84+
* are most likely reported as VGA or SIL164 outputs. We warn here
85+
* to get bug reports for these devices. If none come in for some
86+
* time, we can begin to fail device probing on these values.
87+
*/
88+
vgacrd1 = ast_get_index_reg_mask(ast, AST_IO_VGACRI, 0xd1, AST_IO_VGACRD1_TX_TYPE_MASK);
89+
drm_WARN(dev, vgacrd1 == AST_IO_VGACRD1_TX_ITE66121_VBIOS,
90+
"ITE IT66121 detected, 0x%x, Gen%lu\n", vgacrd1, AST_GEN(ast));
91+
drm_WARN(dev, vgacrd1 == AST_IO_VGACRD1_TX_CH7003_VBIOS,
92+
"Chrontel CH7003 detected, 0x%x, Gen%lu\n", vgacrd1, AST_GEN(ast));
93+
drm_WARN(dev, vgacrd1 == AST_IO_VGACRD1_TX_ANX9807_VBIOS,
94+
"Analogix ANX9807 detected, 0x%x, Gen%lu\n", vgacrd1, AST_GEN(ast));
8095

8196
/* Check 3rd Tx option (digital output afaik) */
8297
ast->tx_chip = AST_TX_NONE;

0 commit comments

Comments
 (0)