Skip to content

Commit a5fdf7d

Browse files
committed
Input: ili210x - remove unneeded suspend and resume handlers
When I2C client is instantiated with I2C_CLIENT_WAKE flag (either via "wakeup-source" device property, or via board info flag), it will mark the main IRQ line as wakeup IRQ, which will ensure that it will be enabled for wakeup when system transitions to suspend state. Since our suspend/resume handlers were only managing IRQ wakeup state, they are no longer needed, and can be removed. Tested-by: Adam Ford <[email protected]> #imx6q-logicpd Tested-by: Sven Van Asbroeck <[email protected]> # ILI2118A variant Signed-off-by: Dmitry Torokhov <[email protected]>
1 parent 172bb5f commit a5fdf7d

File tree

1 file changed

+0
-24
lines changed

1 file changed

+0
-24
lines changed

drivers/input/touchscreen/ili210x.c

Lines changed: 0 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -446,29 +446,6 @@ static int ili210x_i2c_probe(struct i2c_client *client,
446446
return 0;
447447
}
448448

449-
static int __maybe_unused ili210x_i2c_suspend(struct device *dev)
450-
{
451-
struct i2c_client *client = to_i2c_client(dev);
452-
453-
if (device_may_wakeup(&client->dev))
454-
enable_irq_wake(client->irq);
455-
456-
return 0;
457-
}
458-
459-
static int __maybe_unused ili210x_i2c_resume(struct device *dev)
460-
{
461-
struct i2c_client *client = to_i2c_client(dev);
462-
463-
if (device_may_wakeup(&client->dev))
464-
disable_irq_wake(client->irq);
465-
466-
return 0;
467-
}
468-
469-
static SIMPLE_DEV_PM_OPS(ili210x_i2c_pm,
470-
ili210x_i2c_suspend, ili210x_i2c_resume);
471-
472449
static const struct i2c_device_id ili210x_i2c_id[] = {
473450
{ "ili210x", (long)&ili210x_chip },
474451
{ "ili2117", (long)&ili211x_chip },
@@ -488,7 +465,6 @@ MODULE_DEVICE_TABLE(of, ili210x_dt_ids);
488465
static struct i2c_driver ili210x_ts_driver = {
489466
.driver = {
490467
.name = "ili210x_i2c",
491-
.pm = &ili210x_i2c_pm,
492468
.of_match_table = ili210x_dt_ids,
493469
},
494470
.id_table = ili210x_i2c_id,

0 commit comments

Comments
 (0)