Skip to content

Commit a69b3b1

Browse files
KAGA-KOKOsuryasaimadhu
authored andcommitted
platform/x86: Convert to new CPU match macros
The new macro set has a consistent namespace and uses C99 initializers instead of the grufty C89 ones. Get rid the of the local macro wrappers for consistency. Signed-off-by: Thomas Gleixner <[email protected]> Signed-off-by: Borislav Petkov <[email protected]> Reviewed-by: Andy Shevchenko <[email protected]> Reviewed-by: Greg Kroah-Hartman <[email protected]> Link: https://lkml.kernel.org/r/[email protected]
1 parent 2984262 commit a69b3b1

File tree

9 files changed

+37
-47
lines changed

9 files changed

+37
-47
lines changed

drivers/platform/x86/intel-uncore-frequency.c

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -358,15 +358,13 @@ static struct notifier_block uncore_pm_nb = {
358358
.notifier_call = uncore_pm_notify,
359359
};
360360

361-
#define ICPU(model) { X86_VENDOR_INTEL, 6, model, X86_FEATURE_ANY, }
362-
363361
static const struct x86_cpu_id intel_uncore_cpu_ids[] = {
364-
ICPU(INTEL_FAM6_BROADWELL_G),
365-
ICPU(INTEL_FAM6_BROADWELL_X),
366-
ICPU(INTEL_FAM6_BROADWELL_D),
367-
ICPU(INTEL_FAM6_SKYLAKE_X),
368-
ICPU(INTEL_FAM6_ICELAKE_X),
369-
ICPU(INTEL_FAM6_ICELAKE_D),
362+
X86_MATCH_INTEL_FAM6_MODEL(BROADWELL_G, NULL),
363+
X86_MATCH_INTEL_FAM6_MODEL(BROADWELL_X, NULL),
364+
X86_MATCH_INTEL_FAM6_MODEL(BROADWELL_D, NULL),
365+
X86_MATCH_INTEL_FAM6_MODEL(SKYLAKE_X, NULL),
366+
X86_MATCH_INTEL_FAM6_MODEL(ICELAKE_X, NULL),
367+
X86_MATCH_INTEL_FAM6_MODEL(ICELAKE_D, NULL),
370368
{}
371369
};
372370

drivers/platform/x86/intel_int0002_vgpio.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -148,8 +148,8 @@ static struct irq_chip int0002_cht_irqchip = {
148148
};
149149

150150
static const struct x86_cpu_id int0002_cpu_ids[] = {
151-
INTEL_CPU_FAM6(ATOM_SILVERMONT, int0002_byt_irqchip), /* Valleyview, Bay Trail */
152-
INTEL_CPU_FAM6(ATOM_AIRMONT, int0002_cht_irqchip), /* Braswell, Cherry Trail */
151+
X86_MATCH_INTEL_FAM6_MODEL(ATOM_SILVERMONT, &int0002_byt_irqchip),
152+
X86_MATCH_INTEL_FAM6_MODEL(ATOM_AIRMONT, &int0002_cht_irqchip),
153153
{}
154154
};
155155

drivers/platform/x86/intel_mid_powerbtn.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -113,8 +113,8 @@ static const struct mid_pb_ddata mrfld_ddata = {
113113
};
114114

115115
static const struct x86_cpu_id mid_pb_cpu_ids[] = {
116-
INTEL_CPU_FAM6(ATOM_SALTWELL_MID, mfld_ddata),
117-
INTEL_CPU_FAM6(ATOM_SILVERMONT_MID, mrfld_ddata),
116+
X86_MATCH_INTEL_FAM6_MODEL(ATOM_SALTWELL_MID, &mfld_ddata),
117+
X86_MATCH_INTEL_FAM6_MODEL(ATOM_SILVERMONT_MID, &mrfld_ddata),
118118
{}
119119
};
120120

drivers/platform/x86/intel_pmc_core.c

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -871,18 +871,18 @@ static inline void pmc_core_dbgfs_unregister(struct pmc_dev *pmcdev)
871871
#endif /* CONFIG_DEBUG_FS */
872872

873873
static const struct x86_cpu_id intel_pmc_core_ids[] = {
874-
INTEL_CPU_FAM6(SKYLAKE_L, spt_reg_map),
875-
INTEL_CPU_FAM6(SKYLAKE, spt_reg_map),
876-
INTEL_CPU_FAM6(KABYLAKE_L, spt_reg_map),
877-
INTEL_CPU_FAM6(KABYLAKE, spt_reg_map),
878-
INTEL_CPU_FAM6(CANNONLAKE_L, cnp_reg_map),
879-
INTEL_CPU_FAM6(ICELAKE_L, icl_reg_map),
880-
INTEL_CPU_FAM6(ICELAKE_NNPI, icl_reg_map),
881-
INTEL_CPU_FAM6(COMETLAKE, cnp_reg_map),
882-
INTEL_CPU_FAM6(COMETLAKE_L, cnp_reg_map),
883-
INTEL_CPU_FAM6(TIGERLAKE_L, tgl_reg_map),
884-
INTEL_CPU_FAM6(TIGERLAKE, tgl_reg_map),
885-
INTEL_CPU_FAM6(ATOM_TREMONT, tgl_reg_map),
874+
X86_MATCH_INTEL_FAM6_MODEL(SKYLAKE_L, &spt_reg_map),
875+
X86_MATCH_INTEL_FAM6_MODEL(SKYLAKE, &spt_reg_map),
876+
X86_MATCH_INTEL_FAM6_MODEL(KABYLAKE_L, &spt_reg_map),
877+
X86_MATCH_INTEL_FAM6_MODEL(KABYLAKE, &spt_reg_map),
878+
X86_MATCH_INTEL_FAM6_MODEL(CANNONLAKE_L, &cnp_reg_map),
879+
X86_MATCH_INTEL_FAM6_MODEL(ICELAKE_L, &icl_reg_map),
880+
X86_MATCH_INTEL_FAM6_MODEL(ICELAKE_NNPI, &icl_reg_map),
881+
X86_MATCH_INTEL_FAM6_MODEL(COMETLAKE, &cnp_reg_map),
882+
X86_MATCH_INTEL_FAM6_MODEL(COMETLAKE_L, &cnp_reg_map),
883+
X86_MATCH_INTEL_FAM6_MODEL(TIGERLAKE_L, &tgl_reg_map),
884+
X86_MATCH_INTEL_FAM6_MODEL(TIGERLAKE, &tgl_reg_map),
885+
X86_MATCH_INTEL_FAM6_MODEL(ATOM_TREMONT, &tgl_reg_map),
886886
{}
887887
};
888888

drivers/platform/x86/intel_pmc_core_pltdrv.c

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -38,14 +38,14 @@ static struct platform_device pmc_core_device = {
3838
* other list may grow, but this list should not.
3939
*/
4040
static const struct x86_cpu_id intel_pmc_core_platform_ids[] = {
41-
INTEL_CPU_FAM6(SKYLAKE_L, pmc_core_device),
42-
INTEL_CPU_FAM6(SKYLAKE, pmc_core_device),
43-
INTEL_CPU_FAM6(KABYLAKE_L, pmc_core_device),
44-
INTEL_CPU_FAM6(KABYLAKE, pmc_core_device),
45-
INTEL_CPU_FAM6(CANNONLAKE_L, pmc_core_device),
46-
INTEL_CPU_FAM6(ICELAKE_L, pmc_core_device),
47-
INTEL_CPU_FAM6(COMETLAKE, pmc_core_device),
48-
INTEL_CPU_FAM6(COMETLAKE_L, pmc_core_device),
41+
X86_MATCH_INTEL_FAM6_MODEL(SKYLAKE_L, &pmc_core_device),
42+
X86_MATCH_INTEL_FAM6_MODEL(SKYLAKE, &pmc_core_device),
43+
X86_MATCH_INTEL_FAM6_MODEL(KABYLAKE_L, &pmc_core_device),
44+
X86_MATCH_INTEL_FAM6_MODEL(KABYLAKE, &pmc_core_device),
45+
X86_MATCH_INTEL_FAM6_MODEL(CANNONLAKE_L, &pmc_core_device),
46+
X86_MATCH_INTEL_FAM6_MODEL(ICELAKE_L, &pmc_core_device),
47+
X86_MATCH_INTEL_FAM6_MODEL(COMETLAKE, &pmc_core_device),
48+
X86_MATCH_INTEL_FAM6_MODEL(COMETLAKE_L, &pmc_core_device),
4949
{}
5050
};
5151
MODULE_DEVICE_TABLE(x86cpu, intel_pmc_core_platform_ids);

drivers/platform/x86/intel_speed_select_if/isst_if_mbox_msr.c

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -160,10 +160,8 @@ static struct notifier_block isst_pm_nb = {
160160
.notifier_call = isst_pm_notify,
161161
};
162162

163-
#define ICPU(model) { X86_VENDOR_INTEL, 6, model, X86_FEATURE_ANY, }
164-
165163
static const struct x86_cpu_id isst_if_cpu_ids[] = {
166-
ICPU(INTEL_FAM6_SKYLAKE_X),
164+
X86_MATCH_INTEL_FAM6_MODEL(SKYLAKE_X, NULL),
167165
{}
168166
};
169167
MODULE_DEVICE_TABLE(x86cpu, isst_if_cpu_ids);

drivers/platform/x86/intel_telemetry_debugfs.c

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -308,11 +308,10 @@ static struct telemetry_debugfs_conf telem_apl_debugfs_conf = {
308308
};
309309

310310
static const struct x86_cpu_id telemetry_debugfs_cpu_ids[] = {
311-
INTEL_CPU_FAM6(ATOM_GOLDMONT, telem_apl_debugfs_conf),
312-
INTEL_CPU_FAM6(ATOM_GOLDMONT_PLUS, telem_apl_debugfs_conf),
311+
X86_MATCH_INTEL_FAM6_MODEL(ATOM_GOLDMONT, &telem_apl_debugfs_conf),
312+
X86_MATCH_INTEL_FAM6_MODEL(ATOM_GOLDMONT_PLUS, &telem_apl_debugfs_conf),
313313
{}
314314
};
315-
316315
MODULE_DEVICE_TABLE(x86cpu, telemetry_debugfs_cpu_ids);
317316

318317
static int telemetry_debugfs_check_evts(void)

drivers/platform/x86/intel_telemetry_pltdrv.c

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -67,9 +67,6 @@
6767
#define TELEM_CLEAR_VERBOSITY_BITS(x) ((x) &= ~(BIT(27) | BIT(28)))
6868
#define TELEM_SET_VERBOSITY_BITS(x, y) ((x) |= ((y) << 27))
6969

70-
#define TELEM_CPU(model, data) \
71-
{ X86_VENDOR_INTEL, 6, model, X86_FEATURE_ANY, (unsigned long)&data }
72-
7370
enum telemetry_action {
7471
TELEM_UPDATE = 0,
7572
TELEM_ADD,
@@ -183,8 +180,8 @@ static struct telemetry_plt_config telem_glk_config = {
183180
};
184181

185182
static const struct x86_cpu_id telemetry_cpu_ids[] = {
186-
TELEM_CPU(INTEL_FAM6_ATOM_GOLDMONT, telem_apl_config),
187-
TELEM_CPU(INTEL_FAM6_ATOM_GOLDMONT_PLUS, telem_glk_config),
183+
X86_MATCH_INTEL_FAM6_MODEL(ATOM_GOLDMONT, &telem_apl_config),
184+
X86_MATCH_INTEL_FAM6_MODEL(ATOM_GOLDMONT_PLUS, &telem_glk_config),
188185
{}
189186
};
190187

drivers/platform/x86/intel_turbo_max_3.c

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -113,11 +113,9 @@ static int itmt_legacy_cpu_online(unsigned int cpu)
113113
return 0;
114114
}
115115

116-
#define ICPU(model) { X86_VENDOR_INTEL, 6, model, X86_FEATURE_ANY, }
117-
118116
static const struct x86_cpu_id itmt_legacy_cpu_ids[] = {
119-
ICPU(INTEL_FAM6_BROADWELL_X),
120-
ICPU(INTEL_FAM6_SKYLAKE_X),
117+
X86_MATCH_INTEL_FAM6_MODEL(BROADWELL_X, NULL),
118+
X86_MATCH_INTEL_FAM6_MODEL(SKYLAKE_X, NULL),
121119
{}
122120
};
123121

0 commit comments

Comments
 (0)