Skip to content

Commit a6d05e8

Browse files
lucaceresoliakpm00
authored andcommitted
scripts/decode_stacktrace.sh: clarify command line
The syntax as expressed by usage() is not entirely correct: "<modules path>" cannot be passed without "<base path>|auto". Additionally human reading of this syntax can be subject to misunderstanding due the mixture of '|' and '[]'. Improve readability in various ways: * rewrite using two lines for the two allowed usages * add square brackets around "<vmlinux>" as it is optional when using debuginfod-find * move "<modules path>" to inside the square brackets of the 2nd positional parameter * use underscores instead of spaces in <...> strings Link: https://lkml.kernel.org/r/20240823-decode_stacktrace-find_module-improvements-v2-2-d7a57d35558b@bootlin.com Signed-off-by: Luca Ceresoli <[email protected]> Reviewed-by: Stephen Boyd <[email protected]> Cc: Alexis Lothoré (eBPF Foundation) <[email protected]> Cc: Konstantin Khlebnikov <[email protected]> Cc: Sasha Levin <[email protected]> Cc: Thomas Petazzoni <[email protected]> Signed-off-by: Andrew Morton <[email protected]>
1 parent 0f69dc2 commit a6d05e8

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

scripts/decode_stacktrace.sh

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,8 @@
55

66
usage() {
77
echo "Usage:"
8-
echo " $0 -r <release> | <vmlinux> [<base path>|auto] [<modules path>]"
8+
echo " $0 -r <release>"
9+
echo " $0 [<vmlinux> [<base_path>|auto [<modules_path>]]]"
910
}
1011

1112
# Try to find a Rust demangler

0 commit comments

Comments
 (0)