Skip to content

Commit a71dcd3

Browse files
Colin Ian KingpH5
authored andcommitted
reset: remove redundant null check on pointer dev
Pointer dev is being dereferenced when passed to the inlined functon dev_name, however, dev is later being null checked so at first this seems like a potential null pointer dereference. In fact, _reset_control_get_from_lookup is only ever called from __reset_control_get, right after checking dev->of_node hence dev can never be null. Clean this up by removing the redundant null check. Thanks to Philipp Zabel for spotting that dev can never be null. Addresses-Coverity: ("Dereference before null check") Fixes: 6691dff ("reset: add support for non-DT systems") Signed-off-by: Colin Ian King <[email protected]> Reviewed-by: Bartosz Golaszewski <[email protected]> Signed-off-by: Philipp Zabel <[email protected]>
1 parent a188339 commit a71dcd3

File tree

1 file changed

+0
-3
lines changed

1 file changed

+0
-3
lines changed

drivers/reset/core.c

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -694,9 +694,6 @@ __reset_control_get_from_lookup(struct device *dev, const char *con_id,
694694
const char *dev_id = dev_name(dev);
695695
struct reset_control *rstc = NULL;
696696

697-
if (!dev)
698-
return ERR_PTR(-EINVAL);
699-
700697
mutex_lock(&reset_lookup_mutex);
701698

702699
list_for_each_entry(lookup, &reset_lookup_list, list) {

0 commit comments

Comments
 (0)