Skip to content

Commit a765421

Browse files
Tang Bindavem330
authored andcommitted
net: sgi: ioc3-eth: Fix return value check in ioc3eth_probe()
In the function devm_platform_ioremap_resource(), if get resource failed, the return value is ERR_PTR() not NULL. Thus it must be replaced by IS_ERR(), or else it may result in crashes if a critical error path is encountered. Fixes: 0ce5ebd ("mfd: ioc3: Add driver for SGI IOC3 chip") Signed-off-by: Zhang Shengju <[email protected]> Signed-off-by: Tang Bin <[email protected]> Signed-off-by: David S. Miller <[email protected]>
1 parent 41b4bd9 commit a765421

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

drivers/net/ethernet/sgi/ioc3-eth.c

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -848,14 +848,14 @@ static int ioc3eth_probe(struct platform_device *pdev)
848848
ip = netdev_priv(dev);
849849
ip->dma_dev = pdev->dev.parent;
850850
ip->regs = devm_platform_ioremap_resource(pdev, 0);
851-
if (!ip->regs) {
852-
err = -ENOMEM;
851+
if (IS_ERR(ip->regs)) {
852+
err = PTR_ERR(ip->regs);
853853
goto out_free;
854854
}
855855

856856
ip->ssram = devm_platform_ioremap_resource(pdev, 1);
857-
if (!ip->ssram) {
858-
err = -ENOMEM;
857+
if (IS_ERR(ip->ssram)) {
858+
err = PTR_ERR(ip->ssram);
859859
goto out_free;
860860
}
861861

0 commit comments

Comments
 (0)