Skip to content

Commit a78aee9

Browse files
Andre-ARMsudeep-holla
authored andcommitted
arm64: dts: juno: Fix GIC child nodes
The GIC DT nodes for the Juno boards were not fully compliant with the DT binding, which has certain expectations about child nodes and their size and address cells values. Use smaller #address-cells and #size-cells values, as the binding requests, and adjust the reg properties accordingly. This requires adjusting the interrupt nexus nodes as well, as one field of the interrupt-map property depends on the GIC's address-size. Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Andre Przywara <[email protected]> Signed-off-by: Sudeep Holla <[email protected]>
1 parent 336edac commit a78aee9

File tree

1 file changed

+25
-25
lines changed

1 file changed

+25
-25
lines changed

arch/arm64/boot/dts/arm/juno-base.dtsi

Lines changed: 25 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -74,35 +74,35 @@
7474
<0x0 0x2c02f000 0 0x2000>,
7575
<0x0 0x2c04f000 0 0x2000>,
7676
<0x0 0x2c06f000 0 0x2000>;
77-
#address-cells = <2>;
77+
#address-cells = <1>;
7878
#interrupt-cells = <3>;
79-
#size-cells = <2>;
79+
#size-cells = <1>;
8080
interrupt-controller;
8181
interrupts = <GIC_PPI 9 (GIC_CPU_MASK_SIMPLE(6) | IRQ_TYPE_LEVEL_HIGH)>;
82-
ranges = <0 0 0 0x2c1c0000 0 0x40000>;
82+
ranges = <0 0 0x2c1c0000 0x40000>;
8383

8484
v2m_0: v2m@0 {
8585
compatible = "arm,gic-v2m-frame";
8686
msi-controller;
87-
reg = <0 0 0 0x10000>;
87+
reg = <0 0x10000>;
8888
};
8989

9090
v2m@10000 {
9191
compatible = "arm,gic-v2m-frame";
9292
msi-controller;
93-
reg = <0 0x10000 0 0x10000>;
93+
reg = <0x10000 0x10000>;
9494
};
9595

9696
v2m@20000 {
9797
compatible = "arm,gic-v2m-frame";
9898
msi-controller;
99-
reg = <0 0x20000 0 0x10000>;
99+
reg = <0x20000 0x10000>;
100100
};
101101

102102
v2m@30000 {
103103
compatible = "arm,gic-v2m-frame";
104104
msi-controller;
105-
reg = <0 0x30000 0 0x10000>;
105+
reg = <0x30000 0x10000>;
106106
};
107107
};
108108

@@ -546,10 +546,10 @@
546546
<0x42000000 0x40 0x00000000 0x40 0x00000000 0x1 0x00000000>;
547547
#interrupt-cells = <1>;
548548
interrupt-map-mask = <0 0 0 7>;
549-
interrupt-map = <0 0 0 1 &gic 0 0 GIC_SPI 136 IRQ_TYPE_LEVEL_HIGH>,
550-
<0 0 0 2 &gic 0 0 GIC_SPI 137 IRQ_TYPE_LEVEL_HIGH>,
551-
<0 0 0 3 &gic 0 0 GIC_SPI 138 IRQ_TYPE_LEVEL_HIGH>,
552-
<0 0 0 4 &gic 0 0 GIC_SPI 139 IRQ_TYPE_LEVEL_HIGH>;
549+
interrupt-map = <0 0 0 1 &gic 0 GIC_SPI 136 IRQ_TYPE_LEVEL_HIGH>,
550+
<0 0 0 2 &gic 0 GIC_SPI 137 IRQ_TYPE_LEVEL_HIGH>,
551+
<0 0 0 3 &gic 0 GIC_SPI 138 IRQ_TYPE_LEVEL_HIGH>,
552+
<0 0 0 4 &gic 0 GIC_SPI 139 IRQ_TYPE_LEVEL_HIGH>;
553553
msi-parent = <&v2m_0>;
554554
status = "disabled";
555555
iommu-map-mask = <0x0>; /* RC has no means to output PCI RID */
@@ -813,19 +813,19 @@
813813

814814
#interrupt-cells = <1>;
815815
interrupt-map-mask = <0 0 15>;
816-
interrupt-map = <0 0 0 &gic 0 0 GIC_SPI 68 IRQ_TYPE_LEVEL_HIGH>,
817-
<0 0 1 &gic 0 0 GIC_SPI 69 IRQ_TYPE_LEVEL_HIGH>,
818-
<0 0 2 &gic 0 0 GIC_SPI 70 IRQ_TYPE_LEVEL_HIGH>,
819-
<0 0 3 &gic 0 0 GIC_SPI 160 IRQ_TYPE_LEVEL_HIGH>,
820-
<0 0 4 &gic 0 0 GIC_SPI 161 IRQ_TYPE_LEVEL_HIGH>,
821-
<0 0 5 &gic 0 0 GIC_SPI 162 IRQ_TYPE_LEVEL_HIGH>,
822-
<0 0 6 &gic 0 0 GIC_SPI 163 IRQ_TYPE_LEVEL_HIGH>,
823-
<0 0 7 &gic 0 0 GIC_SPI 164 IRQ_TYPE_LEVEL_HIGH>,
824-
<0 0 8 &gic 0 0 GIC_SPI 165 IRQ_TYPE_LEVEL_HIGH>,
825-
<0 0 9 &gic 0 0 GIC_SPI 166 IRQ_TYPE_LEVEL_HIGH>,
826-
<0 0 10 &gic 0 0 GIC_SPI 167 IRQ_TYPE_LEVEL_HIGH>,
827-
<0 0 11 &gic 0 0 GIC_SPI 168 IRQ_TYPE_LEVEL_HIGH>,
828-
<0 0 12 &gic 0 0 GIC_SPI 169 IRQ_TYPE_LEVEL_HIGH>;
816+
interrupt-map = <0 0 0 &gic 0 GIC_SPI 68 IRQ_TYPE_LEVEL_HIGH>,
817+
<0 0 1 &gic 0 GIC_SPI 69 IRQ_TYPE_LEVEL_HIGH>,
818+
<0 0 2 &gic 0 GIC_SPI 70 IRQ_TYPE_LEVEL_HIGH>,
819+
<0 0 3 &gic 0 GIC_SPI 160 IRQ_TYPE_LEVEL_HIGH>,
820+
<0 0 4 &gic 0 GIC_SPI 161 IRQ_TYPE_LEVEL_HIGH>,
821+
<0 0 5 &gic 0 GIC_SPI 162 IRQ_TYPE_LEVEL_HIGH>,
822+
<0 0 6 &gic 0 GIC_SPI 163 IRQ_TYPE_LEVEL_HIGH>,
823+
<0 0 7 &gic 0 GIC_SPI 164 IRQ_TYPE_LEVEL_HIGH>,
824+
<0 0 8 &gic 0 GIC_SPI 165 IRQ_TYPE_LEVEL_HIGH>,
825+
<0 0 9 &gic 0 GIC_SPI 166 IRQ_TYPE_LEVEL_HIGH>,
826+
<0 0 10 &gic 0 GIC_SPI 167 IRQ_TYPE_LEVEL_HIGH>,
827+
<0 0 11 &gic 0 GIC_SPI 168 IRQ_TYPE_LEVEL_HIGH>,
828+
<0 0 12 &gic 0 GIC_SPI 169 IRQ_TYPE_LEVEL_HIGH>;
829829
};
830830

831831
site2: tlx@60000000 {
@@ -835,6 +835,6 @@
835835
ranges = <0 0 0x60000000 0x10000000>;
836836
#interrupt-cells = <1>;
837837
interrupt-map-mask = <0 0>;
838-
interrupt-map = <0 0 &gic 0 0 GIC_SPI 168 IRQ_TYPE_LEVEL_HIGH>;
838+
interrupt-map = <0 0 &gic 0 GIC_SPI 168 IRQ_TYPE_LEVEL_HIGH>;
839839
};
840840
};

0 commit comments

Comments
 (0)