Skip to content

Commit a79343d

Browse files
jhovoldAbhinav Kumar
authored andcommitted
drm/msm/dp: fix IRQ lifetime
Device-managed resources allocated post component bind must be tied to the lifetime of the aggregate DRM device or they will not necessarily be released when binding of the aggregate device is deferred. This is specifically true for the DP IRQ, which will otherwise remain requested so that the next bind attempt fails when requesting the IRQ a second time. Since commit c3bf8e2 ("drm/msm/dp: Add eDP support via aux_bus") this can happen when the aux-bus panel driver has not yet been loaded so that probe is deferred. Fix this by tying the device-managed lifetime of the DP IRQ to the DRM device so that it is released when bind fails. Fixes: c943b49 ("drm/msm/dp: add displayPort driver support") Cc: [email protected] # 5.10 Reviewed-by: Dmitry Baryshkov <[email protected]> Signed-off-by: Johan Hovold <[email protected]> Tested-by: Kuogee Hsieh <[email protected]> Reviewed-by: Kuogee Hsieh <[email protected]> Patchwork: https://patchwork.freedesktop.org/patch/502679/ Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Abhinav Kumar <[email protected]>
1 parent 4c1294d commit a79343d

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/gpu/drm/msm/dp/dp_display.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1249,7 +1249,7 @@ int dp_display_request_irq(struct msm_dp *dp_display)
12491249
return -EINVAL;
12501250
}
12511251

1252-
rc = devm_request_irq(&dp->pdev->dev, dp->irq,
1252+
rc = devm_request_irq(dp_display->drm_dev->dev, dp->irq,
12531253
dp_display_irq_handler,
12541254
IRQF_TRIGGER_HIGH, "dp_display_isr", dp);
12551255
if (rc < 0) {

0 commit comments

Comments
 (0)