Skip to content

Commit a798ff1

Browse files
chaseyuJaegeuk Kim
authored andcommitted
f2fs: fix to add missing iput() in gc_data_segment()
During gc_data_segment(), if inode state is abnormal, it missed to call iput(), fix it. Fixes: b73e528 ("f2fs: reposition unlock_new_inode to prevent accessing invalid inode") Fixes: 9056d64 ("f2fs: fix to do sanity check on inode type during garbage collection") Signed-off-by: Chao Yu <[email protected]> Signed-off-by: Jaegeuk Kim <[email protected]>
1 parent f2526c5 commit a798ff1

File tree

1 file changed

+7
-2
lines changed

1 file changed

+7
-2
lines changed

fs/f2fs/gc.c

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1554,10 +1554,15 @@ static int gc_data_segment(struct f2fs_sb_info *sbi, struct f2fs_summary *sum,
15541554
int err;
15551555

15561556
inode = f2fs_iget(sb, dni.ino);
1557-
if (IS_ERR(inode) || is_bad_inode(inode) ||
1558-
special_file(inode->i_mode))
1557+
if (IS_ERR(inode))
15591558
continue;
15601559

1560+
if (is_bad_inode(inode) ||
1561+
special_file(inode->i_mode)) {
1562+
iput(inode);
1563+
continue;
1564+
}
1565+
15611566
err = f2fs_gc_pinned_control(inode, gc_type, segno);
15621567
if (err == -EAGAIN) {
15631568
iput(inode);

0 commit comments

Comments
 (0)