Skip to content

Commit a7c840b

Browse files
committed
Merge tag 'tag-chrome-platform-firmware-for-v6.10' of git://git.kernel.org/pub/scm/linux/kernel/git/chrome-platform/linux
Pull chrome platform firmware updates from Tzung-Bi Shih: - Set driver owner in the core registration so that coreboot drivers don't need to set it individually * tag 'tag-chrome-platform-firmware-for-v6.10' of git://git.kernel.org/pub/scm/linux/kernel/git/chrome-platform/linux: firmware: google: cbmem: drop driver owner initialization firmware: coreboot: store owner from modules with coreboot_driver_register()
2 parents 59729c8 + 7f20f21 commit a7c840b

File tree

3 files changed

+9
-4
lines changed

3 files changed

+9
-4
lines changed

drivers/firmware/google/cbmem.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -124,7 +124,6 @@ static struct coreboot_driver cbmem_entry_driver = {
124124
.probe = cbmem_entry_probe,
125125
.drv = {
126126
.name = "cbmem",
127-
.owner = THIS_MODULE,
128127
.dev_groups = dev_groups,
129128
},
130129
.id_table = cbmem_ids,

drivers/firmware/google/coreboot_table.c

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -85,13 +85,15 @@ static void coreboot_device_release(struct device *dev)
8585
kfree(device);
8686
}
8787

88-
int coreboot_driver_register(struct coreboot_driver *driver)
88+
int __coreboot_driver_register(struct coreboot_driver *driver,
89+
struct module *owner)
8990
{
9091
driver->drv.bus = &coreboot_bus_type;
92+
driver->drv.owner = owner;
9193

9294
return driver_register(&driver->drv);
9395
}
94-
EXPORT_SYMBOL(coreboot_driver_register);
96+
EXPORT_SYMBOL(__coreboot_driver_register);
9597

9698
void coreboot_driver_unregister(struct coreboot_driver *driver)
9799
{

drivers/firmware/google/coreboot_table.h

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -97,8 +97,12 @@ struct coreboot_driver {
9797
const struct coreboot_device_id *id_table;
9898
};
9999

100+
/* use a macro to avoid include chaining to get THIS_MODULE */
101+
#define coreboot_driver_register(driver) \
102+
__coreboot_driver_register(driver, THIS_MODULE)
100103
/* Register a driver that uses the data from a coreboot table. */
101-
int coreboot_driver_register(struct coreboot_driver *driver);
104+
int __coreboot_driver_register(struct coreboot_driver *driver,
105+
struct module *owner);
102106

103107
/* Unregister a driver that uses the data from a coreboot table. */
104108
void coreboot_driver_unregister(struct coreboot_driver *driver);

0 commit comments

Comments
 (0)