Skip to content

Commit a7c9540

Browse files
Asbjørn Sloth Tønnesenkuba-moo
authored andcommitted
net: qede: use extack in qede_flow_parse_ports()
Convert qede_flow_parse_ports to use extack, and drop the edev argument. Convert DP_NOTICE call to use NL_SET_ERR_MSG_MOD instead. In calls to qede_flow_parse_ports(), use NULL as extack for now, until a subsequent patch makes extack available. Only compile tested. Signed-off-by: Asbjørn Sloth Tønnesen <[email protected]> Reviewed-by: Simon Horman <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Jakub Kicinski <[email protected]>
1 parent d50729f commit a7c9540

File tree

1 file changed

+6
-5
lines changed

1 file changed

+6
-5
lines changed

drivers/net/ethernet/qlogic/qede/qede_filter.c

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1700,16 +1700,17 @@ static int qede_parse_actions(struct qede_dev *edev,
17001700
}
17011701

17021702
static int
1703-
qede_flow_parse_ports(struct qede_dev *edev, struct flow_rule *rule,
1704-
struct qede_arfs_tuple *t)
1703+
qede_flow_parse_ports(struct flow_rule *rule, struct qede_arfs_tuple *t,
1704+
struct netlink_ext_ack *extack)
17051705
{
17061706
if (flow_rule_match_key(rule, FLOW_DISSECTOR_KEY_PORTS)) {
17071707
struct flow_match_ports match;
17081708

17091709
flow_rule_match_ports(rule, &match);
17101710
if ((match.key->src && match.mask->src != htons(U16_MAX)) ||
17111711
(match.key->dst && match.mask->dst != htons(U16_MAX))) {
1712-
DP_NOTICE(edev, "Do not support ports masks\n");
1712+
NL_SET_ERR_MSG_MOD(extack,
1713+
"Do not support ports masks");
17131714
return -EINVAL;
17141715
}
17151716

@@ -1747,7 +1748,7 @@ qede_flow_parse_v6_common(struct qede_dev *edev, struct flow_rule *rule,
17471748
memcpy(&t->dst_ipv6, &match.key->dst, sizeof(addr));
17481749
}
17491750

1750-
err = qede_flow_parse_ports(edev, rule, t);
1751+
err = qede_flow_parse_ports(rule, t, NULL);
17511752
if (err)
17521753
return err;
17531754

@@ -1774,7 +1775,7 @@ qede_flow_parse_v4_common(struct qede_dev *edev, struct flow_rule *rule,
17741775
t->dst_ipv4 = match.key->dst;
17751776
}
17761777

1777-
err = qede_flow_parse_ports(edev, rule, t);
1778+
err = qede_flow_parse_ports(rule, t, NULL);
17781779
if (err)
17791780
return err;
17801781

0 commit comments

Comments
 (0)