Skip to content

Commit a7cacaa

Browse files
vineethribmnamhyung
authored andcommitted
perf sched replay: Fix -r/--repeat command line option for infinity
Currently, the -r/--repeat option accepts values from 0 and complains for -1. The help section specifies: -r, --repeat <n> repeat the workload replay N times (-1: infinite) The -r -1 option raises an error because replay_repeat is defined as an unsigned int. In the current implementation, the workload is repeated n times when -r <n> is used, except when n is 0. When -r is set to 0, the workload is also repeated once. This happens because when -r=0, the run_one_test function is not called. (Note that mutex unlocking, which is essential for child threads spawned to emulate the workload, happens in run_one_test.) However, mutex unlocking is still performed in the destroy_tasks function. Thus, -r=0 results in the workload running once coincidentally. To clarify and maintain the existing logic for -r >= 1 (which runs the workload the specified number of times) and to fix the issue with infinite runs, make -r=0 perform an infinite run. Reviewed-by: James Clark <[email protected]> Signed-off-by: Madadi Vineeth Reddy <[email protected]> Cc: Athira Rajeev <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Namhyung Kim <[email protected]>
1 parent 5484fd2 commit a7cacaa

File tree

2 files changed

+11
-1
lines changed

2 files changed

+11
-1
lines changed

tools/perf/Documentation/perf-sched.txt

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -202,6 +202,13 @@ OPTIONS for 'perf sched timehist'
202202
--state::
203203
Show task state when it switched out.
204204

205+
OPTIONS for 'perf sched replay'
206+
------------------------------
207+
208+
-r::
209+
--repeat <n>::
210+
repeat the workload n times (0: infinite). Default is 10.
211+
205212
SEE ALSO
206213
--------
207214
linkperf:perf-record[1]

tools/perf/builtin-sched.c

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3386,6 +3386,9 @@ static int perf_sched__replay(struct perf_sched *sched)
33863386
sched->thread_funcs_exit = false;
33873387
create_tasks(sched);
33883388
printf("------------------------------------------------------------\n");
3389+
if (sched->replay_repeat == 0)
3390+
sched->replay_repeat = UINT_MAX;
3391+
33893392
for (i = 0; i < sched->replay_repeat; i++)
33903393
run_one_test(sched);
33913394

@@ -3551,7 +3554,7 @@ int cmd_sched(int argc, const char **argv)
35513554
};
35523555
const struct option replay_options[] = {
35533556
OPT_UINTEGER('r', "repeat", &sched.replay_repeat,
3554-
"repeat the workload replay N times (-1: infinite)"),
3557+
"repeat the workload replay N times (0: infinite)"),
35553558
OPT_PARENT(sched_options)
35563559
};
35573560
const struct option map_options[] = {

0 commit comments

Comments
 (0)