Skip to content

Commit a80c4ec

Browse files
suryasaimadhubonzini
authored andcommitted
x86/kvm/pmu: Set AMD's virt PMU version to 1
After commit: 672ff6c ("KVM: x86: Raise #GP when guest vCPU do not support PMU") my AMD guests started #GPing like this: general protection fault: 0000 [#1] PREEMPT SMP CPU: 1 PID: 4355 Comm: bash Not tainted 5.1.0-rc6+ #3 Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.12.0-1 04/01/2014 RIP: 0010:x86_perf_event_update+0x3b/0xa0 with Code: pointing to RDPMC. It is RDPMC because the guest has the hardware watchdog CONFIG_HARDLOCKUP_DETECTOR_PERF enabled which uses perf. Instrumenting kvm_pmu_rdpmc() some, showed that it fails due to: if (!pmu->version) return 1; which the above commit added. Since AMD's PMU leaves the version at 0, that causes the #GP injection into the guest. Set pmu->version arbitrarily to 1 and move it above the non-applicable struct kvm_pmu members. Signed-off-by: Borislav Petkov <[email protected]> Cc: "H. Peter Anvin" <[email protected]> Cc: Ingo Molnar <[email protected]> Cc: Janakarajan Natarajan <[email protected]> Cc: [email protected] Cc: Liran Alon <[email protected]> Cc: Mihai Carabas <[email protected]> Cc: Paolo Bonzini <[email protected]> Cc: Peter Zijlstra <[email protected]> Cc: "Radim Krčmář" <[email protected]> Cc: Thomas Gleixner <[email protected]> Cc: Tom Lendacky <[email protected]> Cc: [email protected] Cc: [email protected] Fixes: 672ff6c ("KVM: x86: Raise #GP when guest vCPU do not support PMU") Signed-off-by: Paolo Bonzini <[email protected]>
1 parent 6f2f845 commit a80c4ec

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

arch/x86/kvm/pmu_amd.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -269,10 +269,10 @@ static void amd_pmu_refresh(struct kvm_vcpu *vcpu)
269269

270270
pmu->counter_bitmask[KVM_PMC_GP] = ((u64)1 << 48) - 1;
271271
pmu->reserved_bits = 0xffffffff00200000ull;
272+
pmu->version = 1;
272273
/* not applicable to AMD; but clean them to prevent any fall out */
273274
pmu->counter_bitmask[KVM_PMC_FIXED] = 0;
274275
pmu->nr_arch_fixed_counters = 0;
275-
pmu->version = 0;
276276
pmu->global_status = 0;
277277
}
278278

0 commit comments

Comments
 (0)