Skip to content

Commit a83bfdc

Browse files
sukrutbchanwoochoi
authored andcommitted
PM / devfreq: mtk-cci: Fix variable deferencing before NULL check
smatch warning: drivers/devfreq/mtk-cci-devfreq.c:135 mtk_ccifreq_target() warn: variable dereferenced before check 'drv' (see line 130) This is based on static analysis only. Compilation tested. Signed-off-by: Sukrut Bellary <[email protected]> Signed-off-by: Chanwoo Choi <[email protected]>
1 parent ccb69e2 commit a83bfdc

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

drivers/devfreq/mtk-cci-devfreq.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -127,7 +127,7 @@ static int mtk_ccifreq_target(struct device *dev, unsigned long *freq,
127127
u32 flags)
128128
{
129129
struct mtk_ccifreq_drv *drv = dev_get_drvdata(dev);
130-
struct clk *cci_pll = clk_get_parent(drv->cci_clk);
130+
struct clk *cci_pll;
131131
struct dev_pm_opp *opp;
132132
unsigned long opp_rate;
133133
int voltage, pre_voltage, inter_voltage, target_voltage, ret;
@@ -139,6 +139,7 @@ static int mtk_ccifreq_target(struct device *dev, unsigned long *freq,
139139
return 0;
140140

141141
inter_voltage = drv->inter_voltage;
142+
cci_pll = clk_get_parent(drv->cci_clk);
142143

143144
opp_rate = *freq;
144145
opp = devfreq_recommended_opp(dev, &opp_rate, 1);

0 commit comments

Comments
 (0)