Skip to content

Commit a8ac783

Browse files
Max Gurtovoymartinkpetersen
authored andcommitted
scsi: target: Make iscsit_register_transport() return void
This function always returns 0. We can make it return void to simplify the code. Also, no caller ever checks the return value of this function. Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Max Gurtovoy <[email protected]> Signed-off-by: Martin K. Petersen <[email protected]>
1 parent bf1a28f commit a8ac783

File tree

2 files changed

+2
-4
lines changed

2 files changed

+2
-4
lines changed

drivers/target/iscsi/iscsi_target_transport.c

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ void iscsit_put_transport(struct iscsit_transport *t)
3131
module_put(t->owner);
3232
}
3333

34-
int iscsit_register_transport(struct iscsit_transport *t)
34+
void iscsit_register_transport(struct iscsit_transport *t)
3535
{
3636
INIT_LIST_HEAD(&t->t_node);
3737

@@ -40,8 +40,6 @@ int iscsit_register_transport(struct iscsit_transport *t)
4040
mutex_unlock(&transport_mutex);
4141

4242
pr_debug("Registered iSCSI transport: %s\n", t->name);
43-
44-
return 0;
4543
}
4644
EXPORT_SYMBOL(iscsit_register_transport);
4745

include/target/iscsi/iscsi_transport.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ static inline void *iscsit_priv_cmd(struct iscsi_cmd *cmd)
4343
* From iscsi_target_transport.c
4444
*/
4545

46-
extern int iscsit_register_transport(struct iscsit_transport *);
46+
extern void iscsit_register_transport(struct iscsit_transport *);
4747
extern void iscsit_unregister_transport(struct iscsit_transport *);
4848
extern struct iscsit_transport *iscsit_get_transport(int);
4949
extern void iscsit_put_transport(struct iscsit_transport *);

0 commit comments

Comments
 (0)