Skip to content

Commit a91e5e3

Browse files
committed
drm/connector: Set DDC pointer in drmm_connector_init
Commit 35a3b82 ("drm/connector: Introduce drmm_connector_init") introduced the function drmm_connector_init() with a parameter for an optional ddc pointer to the i2c controller used to access the DDC bus. However, the underlying call to __drm_connector_init() was always setting it to NULL instead of passing the ddc argument around. This resulted in unexpected null pointer dereference on platforms expecting to get a DDC controller. Fixes: 35a3b82 ("drm/connector: Introduce drmm_connector_init") Reviewed-by: Thomas Zimmermann <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Maxime Ripard <[email protected]>
1 parent 7089003 commit a91e5e3

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/gpu/drm/drm_connector.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -435,7 +435,7 @@ int drmm_connector_init(struct drm_device *dev,
435435
if (drm_WARN_ON(dev, funcs && funcs->destroy))
436436
return -EINVAL;
437437

438-
ret = __drm_connector_init(dev, connector, funcs, connector_type, NULL);
438+
ret = __drm_connector_init(dev, connector, funcs, connector_type, ddc);
439439
if (ret)
440440
return ret;
441441

0 commit comments

Comments
 (0)