Skip to content

Commit a952986

Browse files
committed
genksyms: remove Makefile hack
This workaround was introduced for suppressing the reduce/reduce conflict warnings because the %expect-rr directive, which is applicable only to GLR parsers, cannot be used for genksyms. Since there are no longer any conflicts, this Makefile hack is now unnecessary. Signed-off-by: Masahiro Yamada <[email protected]> Acked-by: Nicolas Schier <[email protected]>
1 parent 668de2b commit a952986

File tree

1 file changed

+0
-18
lines changed

1 file changed

+0
-18
lines changed

scripts/genksyms/Makefile

Lines changed: 0 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -4,24 +4,6 @@ hostprogs-always-y += genksyms
44

55
genksyms-objs := genksyms.o parse.tab.o lex.lex.o
66

7-
# FIXME: fix the ambiguous grammar in parse.y and delete this hack
8-
#
9-
# Suppress shift/reduce, reduce/reduce conflicts warnings
10-
# unless W=1 is specified.
11-
#
12-
# Just in case, run "$(YACC) --version" without suppressing stderr
13-
# so that 'bison: not found' will be displayed if it is missing.
14-
ifeq ($(findstring 1,$(KBUILD_EXTRA_WARN)),)
15-
16-
quiet_cmd_bison_no_warn = $(quiet_cmd_bison)
17-
cmd_bison_no_warn = $(YACC) --version >/dev/null; \
18-
$(cmd_bison) 2>/dev/null
19-
20-
$(obj)/pars%.tab.c $(obj)/pars%.tab.h: $(src)/pars%.y FORCE
21-
$(call if_changed,bison_no_warn)
22-
23-
endif
24-
257
# -I needed for generated C source to include headers in source tree
268
HOSTCFLAGS_parse.tab.o := -I $(src)
279
HOSTCFLAGS_lex.lex.o := -I $(src)

0 commit comments

Comments
 (0)