HID: logitech-hidpp: HID: make const array consumer_rdesc_start static

Colin Ian King · Jiri Kosina · commit a96a8a576bf5 · 2019-05-22T13:18:44.000+02:00
Don't populate the array consumer_rdesc_start on the stack but instead
make it static. Makes the object code smaller by 88 bytes.

Before:
   text	   data	    bss	    dec	    hex	filename
  59155	   9840	    448	  69443	  10f43	drivers/hid/hid-logitech-hidpp.o

After:
   text	   data	    bss	    dec	    hex	filename
  59003	   9904	    448	  69355	  10eeb	drivers/hid/hid-logitech-hidpp.o

(gcc version 8.3.0, amd64)

Signed-off-by: Colin Ian King &lt;colin.king@canonical.com&gt;
Signed-off-by: Jiri Kosina &lt;jkosina@suse.cz&gt;
diff --git a/drivers/hid/hid-logitech-hidpp.c b/drivers/hid/hid-logitech-hidpp.c
@@ -2862,7 +2862,7 @@ static u8 *hidpp10_consumer_keys_report_fixup(struct hidpp_device *hidpp,
 					      u8 *_rdesc, unsigned int *rsize)
 {
 	/* Note 0 terminated so we can use strnstr to search for this. */
-	const char consumer_rdesc_start[] = {
+	static const char consumer_rdesc_start[] = {
 		0x05, 0x0C,	/* USAGE_PAGE (Consumer Devices)       */
 		0x09, 0x01,	/* USAGE (Consumer Control)            */
 		0xA1, 0x01,	/* COLLECTION (Application)            */

Original file line number	Diff line number	Diff line change
`@@ -2862,7 +2862,7 @@ static u8 hidpp10_consumer_keys_report_fixup(struct hidpp_device hidpp,`
`2862`	`2862`	`u8 _rdesc, unsigned int rsize)`
`2863`	`2863`	`{`
`2864`	`2864`	`/* Note 0 terminated so we can use strnstr to search for this. */`
`2865`		`- const char consumer_rdesc_start[] = {`
	`2865`	`+ static const char consumer_rdesc_start[] = {`
`2866`	`2866`	`0x05, 0x0C, /* USAGE_PAGE (Consumer Devices) */`
`2867`	`2867`	`0x09, 0x01, /* USAGE (Consumer Control) */`
`2868`	`2868`	`0xA1, 0x01, /* COLLECTION (Application) */`