Skip to content

Commit a96b0d0

Browse files
Weilong Chenmstsirkin
authored andcommitted
virtio-mem: Fix build error due to improper use 'select'
As noted in: https://www.kernel.org/doc/Documentation/kbuild/kconfig-language.txt "select should be used with care. select will force a symbol to a value without visiting the dependencies." Config VIRTIO_MEM should not select CONTIG_ALLOC directly. Otherwise it will cause an error: https://bugzilla.kernel.org/show_bug.cgi?id=208245 Signed-off-by: Weilong Chen <[email protected]> Link: https://lore.kernel.org/r/[email protected] Acked-by: Randy Dunlap <[email protected]> # build-tested Signed-off-by: Michael S. Tsirkin <[email protected]> Acked-by: Jason Wang <[email protected]> Acked-by: David Hildenbrand <[email protected]>
1 parent 168c358 commit a96b0d0

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/virtio/Kconfig

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@ config VIRTIO_MEM
8585
depends on VIRTIO
8686
depends on MEMORY_HOTPLUG_SPARSE
8787
depends on MEMORY_HOTREMOVE
88-
select CONTIG_ALLOC
88+
depends on CONTIG_ALLOC
8989
help
9090
This driver provides access to virtio-mem paravirtualized memory
9191
devices, allowing to hotplug and hotunplug memory.

0 commit comments

Comments
 (0)