Skip to content

Commit a9909c2

Browse files
Lee Jonesrafaeljw
authored andcommitted
cpufreq: cpufreq: Demote lots of function headers unworthy of kerneldoc status
Also provide missing function parameter description for 'cpu' and 'policy'. Fixes the following W=1 kernel build warning(s): drivers/cpufreq/cpufreq.c:60: warning: cannot understand function prototype: 'struct cpufreq_driver *cpufreq_driver; ' drivers/cpufreq/cpufreq.c:90: warning: Function parameter or member 'cpufreq_policy_notifier_list' not described in 'BLOCKING_NOTIFIER_HEAD' drivers/cpufreq/cpufreq.c:312: warning: Function parameter or member 'val' not described in 'adjust_jiffies' drivers/cpufreq/cpufreq.c:312: warning: Function parameter or member 'ci' not described in 'adjust_jiffies' drivers/cpufreq/cpufreq.c:538: warning: Function parameter or member 'policy' not described in 'cpufreq_driver_resolve_freq' drivers/cpufreq/cpufreq.c:686: warning: Function parameter or member 'file_name' not described in 'show_one' drivers/cpufreq/cpufreq.c:686: warning: Function parameter or member 'object' not described in 'show_one' drivers/cpufreq/cpufreq.c:731: warning: Function parameter or member 'file_name' not described in 'store_one' drivers/cpufreq/cpufreq.c:731: warning: Function parameter or member 'object' not described in 'store_one' drivers/cpufreq/cpufreq.c:741: warning: Function parameter or member 'policy' not described in 'show_cpuinfo_cur_freq' drivers/cpufreq/cpufreq.c:741: warning: Function parameter or member 'buf' not described in 'show_cpuinfo_cur_freq' drivers/cpufreq/cpufreq.c:754: warning: Function parameter or member 'policy' not described in 'show_scaling_governor' drivers/cpufreq/cpufreq.c:754: warning: Function parameter or member 'buf' not described in 'show_scaling_governor' drivers/cpufreq/cpufreq.c:770: warning: Function parameter or member 'policy' not described in 'store_scaling_governor' drivers/cpufreq/cpufreq.c:770: warning: Function parameter or member 'buf' not described in 'store_scaling_governor' drivers/cpufreq/cpufreq.c:770: warning: Function parameter or member 'count' not described in 'store_scaling_governor' drivers/cpufreq/cpufreq.c:806: warning: Function parameter or member 'policy' not described in 'show_scaling_driver' drivers/cpufreq/cpufreq.c:806: warning: Function parameter or member 'buf' not described in 'show_scaling_driver' drivers/cpufreq/cpufreq.c:815: warning: Function parameter or member 'policy' not described in 'show_scaling_available_governors' drivers/cpufreq/cpufreq.c:815: warning: Function parameter or member 'buf' not described in 'show_scaling_available_governors' drivers/cpufreq/cpufreq.c:859: warning: Function parameter or member 'policy' not described in 'show_related_cpus' drivers/cpufreq/cpufreq.c:859: warning: Function parameter or member 'buf' not described in 'show_related_cpus' drivers/cpufreq/cpufreq.c:867: warning: Function parameter or member 'policy' not described in 'show_affected_cpus' drivers/cpufreq/cpufreq.c:867: warning: Function parameter or member 'buf' not described in 'show_affected_cpus' drivers/cpufreq/cpufreq.c:901: warning: Function parameter or member 'policy' not described in 'show_bios_limit' drivers/cpufreq/cpufreq.c:901: warning: Function parameter or member 'buf' not described in 'show_bios_limit' drivers/cpufreq/cpufreq.c:1625: warning: Function parameter or member 'dev' not described in 'cpufreq_remove_dev' drivers/cpufreq/cpufreq.c:1625: warning: Function parameter or member 'sif' not described in 'cpufreq_remove_dev' drivers/cpufreq/cpufreq.c:2380: warning: Function parameter or member 'cpu' not described in 'cpufreq_get_policy' drivers/cpufreq/cpufreq.c:2771: warning: Function parameter or member 'driver' not described in 'cpufreq_unregister_driver' Signed-off-by: Lee Jones <[email protected]> Acked-by: Viresh Kumar <[email protected]> Signed-off-by: Rafael J. Wysocki <[email protected]>
1 parent 19231a8 commit a9909c2

File tree

1 file changed

+17
-15
lines changed

1 file changed

+17
-15
lines changed

drivers/cpufreq/cpufreq.c

Lines changed: 17 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ static LIST_HEAD(cpufreq_governor_list);
5252

5353
static char default_governor[CPUFREQ_NAME_LEN];
5454

55-
/**
55+
/*
5656
* The "cpufreq driver" - the arch- or hardware-dependent low
5757
* level driver of CPUFreq support, and its spinlock. This lock
5858
* also protects the cpufreq_cpu_data array.
@@ -80,7 +80,7 @@ static int cpufreq_set_policy(struct cpufreq_policy *policy,
8080
struct cpufreq_governor *new_gov,
8181
unsigned int new_pol);
8282

83-
/**
83+
/*
8484
* Two notifier lists: the "policy" list is involved in the
8585
* validation process for a new CPU frequency policy; the
8686
* "transition" list for kernel code that needs to handle
@@ -300,7 +300,7 @@ struct cpufreq_policy *cpufreq_cpu_acquire(unsigned int cpu)
300300
* EXTERNALLY AFFECTING FREQUENCY CHANGES *
301301
*********************************************************************/
302302

303-
/**
303+
/*
304304
* adjust_jiffies - adjust the system "loops_per_jiffy"
305305
*
306306
* This function alters the system "loops_per_jiffy" for the clock
@@ -526,6 +526,7 @@ EXPORT_SYMBOL_GPL(cpufreq_disable_fast_switch);
526526
/**
527527
* cpufreq_driver_resolve_freq - Map a target frequency to a driver-supported
528528
* one.
529+
* @policy: associated policy to interrogate
529530
* @target_freq: target frequency to resolve.
530531
*
531532
* The target to driver frequency mapping is cached in the policy.
@@ -670,7 +671,7 @@ static struct cpufreq_governor *cpufreq_parse_governor(char *str_governor)
670671
return get_governor(str_governor);
671672
}
672673

673-
/**
674+
/*
674675
* cpufreq_per_cpu_attr_read() / show_##file_name() -
675676
* print out cpufreq information
676677
*
@@ -712,7 +713,7 @@ static ssize_t show_scaling_cur_freq(struct cpufreq_policy *policy, char *buf)
712713
return ret;
713714
}
714715

715-
/**
716+
/*
716717
* cpufreq_per_cpu_attr_write() / store_##file_name() - sysfs write access
717718
*/
718719
#define store_one(file_name, object) \
@@ -733,7 +734,7 @@ static ssize_t store_##file_name \
733734
store_one(scaling_min_freq, min);
734735
store_one(scaling_max_freq, max);
735736

736-
/**
737+
/*
737738
* show_cpuinfo_cur_freq - current CPU frequency as detected by hardware
738739
*/
739740
static ssize_t show_cpuinfo_cur_freq(struct cpufreq_policy *policy,
@@ -747,7 +748,7 @@ static ssize_t show_cpuinfo_cur_freq(struct cpufreq_policy *policy,
747748
return sprintf(buf, "<unknown>\n");
748749
}
749750

750-
/**
751+
/*
751752
* show_scaling_governor - show the current policy for the specified CPU
752753
*/
753754
static ssize_t show_scaling_governor(struct cpufreq_policy *policy, char *buf)
@@ -762,7 +763,7 @@ static ssize_t show_scaling_governor(struct cpufreq_policy *policy, char *buf)
762763
return -EINVAL;
763764
}
764765

765-
/**
766+
/*
766767
* store_scaling_governor - store policy for the specified CPU
767768
*/
768769
static ssize_t store_scaling_governor(struct cpufreq_policy *policy,
@@ -799,15 +800,15 @@ static ssize_t store_scaling_governor(struct cpufreq_policy *policy,
799800
return ret ? ret : count;
800801
}
801802

802-
/**
803+
/*
803804
* show_scaling_driver - show the cpufreq driver currently loaded
804805
*/
805806
static ssize_t show_scaling_driver(struct cpufreq_policy *policy, char *buf)
806807
{
807808
return scnprintf(buf, CPUFREQ_NAME_PLEN, "%s\n", cpufreq_driver->name);
808809
}
809810

810-
/**
811+
/*
811812
* show_scaling_available_governors - show the available CPUfreq governors
812813
*/
813814
static ssize_t show_scaling_available_governors(struct cpufreq_policy *policy,
@@ -851,7 +852,7 @@ ssize_t cpufreq_show_cpus(const struct cpumask *mask, char *buf)
851852
}
852853
EXPORT_SYMBOL_GPL(cpufreq_show_cpus);
853854

854-
/**
855+
/*
855856
* show_related_cpus - show the CPUs affected by each transition even if
856857
* hw coordination is in use
857858
*/
@@ -860,7 +861,7 @@ static ssize_t show_related_cpus(struct cpufreq_policy *policy, char *buf)
860861
return cpufreq_show_cpus(policy->related_cpus, buf);
861862
}
862863

863-
/**
864+
/*
864865
* show_affected_cpus - show the CPUs affected by each transition
865866
*/
866867
static ssize_t show_affected_cpus(struct cpufreq_policy *policy, char *buf)
@@ -894,7 +895,7 @@ static ssize_t show_scaling_setspeed(struct cpufreq_policy *policy, char *buf)
894895
return policy->governor->show_setspeed(policy, buf);
895896
}
896897

897-
/**
898+
/*
898899
* show_bios_limit - show the current cpufreq HW/BIOS limitation
899900
*/
900901
static ssize_t show_bios_limit(struct cpufreq_policy *policy, char *buf)
@@ -1616,7 +1617,7 @@ static int cpufreq_offline(unsigned int cpu)
16161617
return 0;
16171618
}
16181619

1619-
/**
1620+
/*
16201621
* cpufreq_remove_dev - remove a CPU device
16211622
*
16221623
* Removes the cpufreq interface for a CPU device.
@@ -2373,6 +2374,7 @@ EXPORT_SYMBOL_GPL(cpufreq_unregister_governor);
23732374
* cpufreq_get_policy - get the current cpufreq_policy
23742375
* @policy: struct cpufreq_policy into which the current cpufreq_policy
23752376
* is written
2377+
* @cpu: CPU to find the policy for
23762378
*
23772379
* Reads the current cpufreq policy.
23782380
*/
@@ -2759,7 +2761,7 @@ int cpufreq_register_driver(struct cpufreq_driver *driver_data)
27592761
}
27602762
EXPORT_SYMBOL_GPL(cpufreq_register_driver);
27612763

2762-
/**
2764+
/*
27632765
* cpufreq_unregister_driver - unregister the current CPUFreq driver
27642766
*
27652767
* Unregister the current CPUFreq driver. Only call this if you have

0 commit comments

Comments
 (0)